crypto: algapi - remove unused notifications
authorEric Biggers <ebiggers@google.com>
Fri, 29 Dec 2017 16:06:46 +0000 (10:06 -0600)
committerHerbert Xu <herbert@gondor.apana.org.au>
Fri, 5 Jan 2018 07:43:10 +0000 (18:43 +1100)
There is a message posted to the crypto notifier chain when an algorithm
is unregistered, and when a template is registered or unregistered.  But
nothing is listening for those messages; currently there are only
listeners for the algorithm request and registration messages.

Get rid of these unused notifications for now.

Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
crypto/algapi.c
crypto/internal.h

index 8084a76e01d848f0214cbe45a537a3d879c00c60..9895cafcce7ecd64cb1b44e5148e8ed2ba661725 100644 (file)
@@ -123,7 +123,6 @@ static void crypto_remove_instance(struct crypto_instance *inst,
        if (!tmpl || !crypto_tmpl_get(tmpl))
                return;
 
-       crypto_notify(CRYPTO_MSG_ALG_UNREGISTER, &inst->alg);
        list_move(&inst->alg.cra_list, list);
        hlist_del(&inst->list);
        inst->alg.cra_destroy = crypto_destroy_instance;
@@ -380,7 +379,6 @@ static int crypto_remove_alg(struct crypto_alg *alg, struct list_head *list)
 
        alg->cra_flags |= CRYPTO_ALG_DEAD;
 
-       crypto_notify(CRYPTO_MSG_ALG_UNREGISTER, alg);
        list_del_init(&alg->cra_list);
        crypto_remove_spawns(alg, list, NULL);
 
@@ -458,7 +456,6 @@ int crypto_register_template(struct crypto_template *tmpl)
        }
 
        list_add(&tmpl->list, &crypto_template_list);
-       crypto_notify(CRYPTO_MSG_TMPL_REGISTER, tmpl);
        err = 0;
 out:
        up_write(&crypto_alg_sem);
@@ -485,8 +482,6 @@ void crypto_unregister_template(struct crypto_template *tmpl)
                BUG_ON(err);
        }
 
-       crypto_notify(CRYPTO_MSG_TMPL_UNREGISTER, tmpl);
-
        up_write(&crypto_alg_sem);
 
        hlist_for_each_entry_safe(inst, n, list, list) {
index 1388af6da85ae4e361654fdccb2d876edfe9627d..5ac27fba10e82528411a0874492ad75e861611ae 100644 (file)
@@ -30,9 +30,6 @@
 enum {
        CRYPTO_MSG_ALG_REQUEST,
        CRYPTO_MSG_ALG_REGISTER,
-       CRYPTO_MSG_ALG_UNREGISTER,
-       CRYPTO_MSG_TMPL_REGISTER,
-       CRYPTO_MSG_TMPL_UNREGISTER,
 };
 
 struct crypto_instance;