ASoC: ml26124: Fix negative array index read
authorTakashi Iwai <tiwai@suse.de>
Wed, 30 Oct 2013 17:40:04 +0000 (18:40 +0100)
committerMark Brown <broonie@linaro.org>
Wed, 30 Oct 2013 21:33:08 +0000 (14:33 -0700)
get_coeff() may return an error.

Spotted by coverity CID 703394.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Mark Brown <broonie@linaro.org>
sound/soc/codecs/ml26124.c

index 26118828782b9b5b4ced3c372ccf128b971cebde..185fa3bc3052c826dd71f74cf0e52b6945aaae2c 100644 (file)
@@ -342,6 +342,8 @@ static int ml26124_hw_params(struct snd_pcm_substream *substream,
        struct ml26124_priv *priv = snd_soc_codec_get_drvdata(codec);
        int i = get_coeff(priv->mclk, params_rate(hw_params));
 
+       if (i < 0)
+               return i;
        priv->substream = substream;
        priv->rate = params_rate(hw_params);