Input: tps65218-pwrbutton - drop unnecessary call to platform_set_drvdata
authorGuenter Roeck <linux@roeck-us.net>
Wed, 18 Jan 2017 19:42:44 +0000 (11:42 -0800)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Wed, 18 Jan 2017 19:49:17 +0000 (11:49 -0800)
There is no call to platform_get_drvdata() or dev_get_drvdata().
Drop the unnecessary call to platform_set_drvdata().

Also use existing variable 'dev' instead of dereferencing it several times.

Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/misc/tps65218-pwrbutton.c

index 3273217ce80c8feecdf7d1b4d4c98c63264901b1..65384754714d41b41025758705bb1e1d99acf5d5 100644 (file)
@@ -95,7 +95,7 @@ static int tps6521x_pb_probe(struct platform_device *pdev)
        int error;
        int irq;
 
-       match = of_match_node(of_tps6521x_pb_match, pdev->dev.of_node);
+       match = of_match_node(of_tps6521x_pb_match, dev->of_node);
        if (!match)
                return -ENXIO;
 
@@ -118,10 +118,9 @@ static int tps6521x_pb_probe(struct platform_device *pdev)
 
        input_set_capability(idev, EV_KEY, KEY_POWER);
 
-       pwr->regmap = dev_get_regmap(pdev->dev.parent, NULL);
+       pwr->regmap = dev_get_regmap(dev->parent, NULL);
        pwr->dev = dev;
        pwr->idev = idev;
-       platform_set_drvdata(pdev, pwr);
        device_init_wakeup(dev, true);
 
        irq = platform_get_irq(pdev, 0);
@@ -136,8 +135,7 @@ static int tps6521x_pb_probe(struct platform_device *pdev)
                                                IRQF_ONESHOT,
                                          pwr->data->name, pwr);
        if (error) {
-               dev_err(dev, "failed to request IRQ #%d: %d\n",
-                       irq, error);
+               dev_err(dev, "failed to request IRQ #%d: %d\n", irq, error);
                return error;
        }