net: calxedaxgmac: add uc and mc filter addresses in promiscuous mode
authorRob Herring <rob.herring@calxeda.com>
Mon, 30 Sep 2013 20:12:16 +0000 (15:12 -0500)
committerDavid S. Miller <davem@davemloft.net>
Wed, 2 Oct 2013 20:10:29 +0000 (16:10 -0400)
Even in promiscuous mode, we need to add filter addresses for correct
operation. This fixes silent failures when using a bridge and adding
addresses using the "bridge fdb add" command.

Signed-off-by: Rob Herring <rob.herring@calxeda.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/calxeda/xgmac.c

index 94358d234e7389b5114be07fdd09e6641163704a..35da09b80c7cf029cbf36024ad1c089d7ea327df 100644 (file)
@@ -1291,10 +1291,8 @@ static void xgmac_set_rx_mode(struct net_device *dev)
        netdev_dbg(priv->dev, "# mcasts %d, # unicast %d\n",
                 netdev_mc_count(dev), netdev_uc_count(dev));
 
-       if (dev->flags & IFF_PROMISC) {
-               writel(XGMAC_FRAME_FILTER_PR, ioaddr + XGMAC_FRAME_FILTER);
-               return;
-       }
+       if (dev->flags & IFF_PROMISC)
+               value |= XGMAC_FRAME_FILTER_PR;
 
        memset(hash_filter, 0, sizeof(hash_filter));