virtio_net: Clean up set_skb_frag()
authorKrishna Kumar <krkumar2@in.ibm.com>
Wed, 19 Oct 2011 22:17:27 +0000 (22:17 +0000)
committerDavid S. Miller <davem@davemloft.net>
Thu, 20 Oct 2011 08:53:56 +0000 (04:53 -0400)
Remove manual initialization in set_skb_frag, and instead
use __skb_fill_page_desc() to do the same. Patch tested
on net-next.

Signed-off-by: Krishna Kumar <krkumar2@in.ibm.com>
Acked-by: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/virtio_net.c

index 0d4841bed0f97da9329c9882ecf5d587db49d80e..abbf34fcf4cdba8e16ca6a75c5434e761c336915 100644 (file)
@@ -143,18 +143,15 @@ static void skb_xmit_done(struct virtqueue *svq)
 static void set_skb_frag(struct sk_buff *skb, struct page *page,
                         unsigned int offset, unsigned int *len)
 {
+       int size = min((unsigned)PAGE_SIZE - offset, *len);
        int i = skb_shinfo(skb)->nr_frags;
-       skb_frag_t *f;
 
-       f = &skb_shinfo(skb)->frags[i];
-       skb_frag_size_set(f, min((unsigned)PAGE_SIZE - offset, *len));
-       f->page_offset = offset;
-       __skb_frag_set_page(f, page);
+       __skb_fill_page_desc(skb, i, page, offset, size);
 
-       skb->data_len += skb_frag_size(f);
-       skb->len += skb_frag_size(f);
+       skb->data_len += size;
+       skb->len += size;
        skb_shinfo(skb)->nr_frags++;
-       *len -= skb_frag_size(f);
+       *len -= size;
 }
 
 static struct sk_buff *page_to_skb(struct virtnet_info *vi,