drm/i915: debug print all of the DPCD we have
authorJani Nikula <jani.nikula@intel.com>
Thu, 25 Oct 2012 07:58:10 +0000 (10:58 +0300)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Fri, 26 Oct 2012 18:32:24 +0000 (20:32 +0200)
At some point the DPCD size was increased, but the debug print not. While
at it, switch to using hex dump.

Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Reviewed-by: Mika Kuoppala <mika.kuoppala@intel.com>
Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
drivers/gpu/drm/i915/intel_dp.c

index 2a9998ae3998919d7ca4325921c01ed84820f15b..2cce6bc755e5e92af5407f032a7c6b0e6a43c0ae 100644 (file)
@@ -2279,6 +2279,7 @@ intel_dp_detect(struct drm_connector *connector, bool force)
        struct drm_device *dev = intel_dp->base.base.dev;
        enum drm_connector_status status;
        struct edid *edid = NULL;
+       char dpcd_hex_dump[sizeof(intel_dp->dpcd) * 3];
 
        intel_dp->has_audio = false;
 
@@ -2287,10 +2288,9 @@ intel_dp_detect(struct drm_connector *connector, bool force)
        else
                status = g4x_dp_detect(intel_dp);
 
-       DRM_DEBUG_KMS("DPCD: %02hx%02hx%02hx%02hx%02hx%02hx%02hx%02hx\n",
-                     intel_dp->dpcd[0], intel_dp->dpcd[1], intel_dp->dpcd[2],
-                     intel_dp->dpcd[3], intel_dp->dpcd[4], intel_dp->dpcd[5],
-                     intel_dp->dpcd[6], intel_dp->dpcd[7]);
+       hex_dump_to_buffer(intel_dp->dpcd, sizeof(intel_dp->dpcd),
+                          32, 1, dpcd_hex_dump, sizeof(dpcd_hex_dump), false);
+       DRM_DEBUG_KMS("DPCD: %s\n", dpcd_hex_dump);
 
        if (status != connector_status_connected)
                return status;