arm64: dts: amlogic: remove ethernet-phy-idAAAA.BBBB compatible strings
authorMartin Blumenstingl <martin.blumenstingl@googlemail.com>
Sat, 11 May 2019 17:45:34 +0000 (19:45 +0200)
committerKevin Hilman <khilman@baylibre.com>
Tue, 21 May 2019 17:58:40 +0000 (10:58 -0700)
The Ethernet PHY documentation
(Documentation/devicetree/bindings/net/phy.txt) states that:
  If the PHY reports an incorrect ID (or none at all) then the
  "compatible" list may contain an entry with the correct PHY ID in the
  form: "ethernet-phy-idAAAA.BBBB"

An older version of the documentation suggested that the compatible
string can be used when the PHY ID is known.

Remove the ethernet-phy-id compatible string and add a comment with the
PHY ID instead.
This is a no-op on boards which are shipped with the PHY that was
listed (= all known cases). However, if a board manufacturer decides to
ship a different PHY we will now load and use the correct driver because
we ask the PHY to identify itself.

Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Kevin Hilman <khilman@baylibre.com>
arch/arm64/boot/dts/amlogic/meson-gxl-s905d-p230.dts
arch/arm64/boot/dts/amlogic/meson-gxm-nexbox-a1.dts
arch/arm64/boot/dts/amlogic/meson-gxm-q200.dts
arch/arm64/boot/dts/amlogic/meson-gxm-rbox-pro.dts

index 0c8e8305b1f3d4c73766b47a4094b742f210c624..767b1763a6124c7681386d92cf97008c37ac1a8b 100644 (file)
@@ -81,7 +81,7 @@
 
 &external_mdio {
        external_phy: ethernet-phy@0 {
-               compatible = "ethernet-phy-id001c.c916", "ethernet-phy-ieee802.3-c22";
+               /* Realtek RTL8211F (0x001cc916) */
                reg = <0>;
                max-speed = <1000>;
                interrupt-parent = <&gpio_intc>;
index 96fdb1856b7b44ebea0506763f3fdf9f7b370f48..29715eae14a9aa6143307009952ca062827e7509 100644 (file)
 
 &external_mdio {
        external_phy: ethernet-phy@0 {
-               compatible = "ethernet-phy-id001c.c916", "ethernet-phy-ieee802.3-c22";
+               /* Realtek RTL8211F (0x001cc916) */
                reg = <0>;
                max-speed = <1000>;
        };
index 73d656e4aadeae9be4346de49de06aa49a91ee2e..8939c0fc5b6254f1092f33b10de90af7dfc77914 100644 (file)
@@ -63,7 +63,7 @@
 
 &external_mdio {
        external_phy: ethernet-phy@0 {
-               compatible = "ethernet-phy-id001c.c916", "ethernet-phy-ieee802.3-c22";
+               /* Realtek RTL8211F (0x001cc916) */
                reg = <0>;
                max-speed = <1000>;
                interrupt-parent = <&gpio_intc>;
index 3d499675c9a86576a32fb257cf63c86e930d8877..13de1e8f58b5bae5f8e4a4c622e0781f91f78818 100644 (file)
 
 &external_mdio {
        external_phy: ethernet-phy@0 {
-               compatible = "ethernet-phy-id001c.c916", "ethernet-phy-ieee802.3-c22";
+               /* Realtek RTL8211F (0x001cc916) */
                reg = <0>;
                max-speed = <1000>;
        };