drm/i915/fbdev: Always forward hotplug events
authorDaniel Vetter <daniel.vetter@ffwll.ch>
Thu, 6 Jul 2017 13:00:19 +0000 (15:00 +0200)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Fri, 14 Jul 2017 13:15:01 +0000 (15:15 +0200)
With deferred fbdev setup we always need to forward hotplug events,
even if fbdev isn't fully set up yet. Otherwise the deferred setup
will neer happen.

Originally this check was added in

commit c45eb4fed12d278d3619f1904885bd0d7bcbf036 (tag: drm-intel-next-fixes-2016-08-05)
Author: Chris Wilson <chris@chris-wilson.co.uk>
Date:   Wed Jul 13 18:34:45 2016 +0100

    drm/i915/fbdev: Check for the framebuffer before use

But the specific case of the hotplug function blowing up was fixed in

commit 50c3dc970a09b3b60422a58934cc27a413288bab
Author: Daniel Vetter <daniel.vetter@ffwll.ch>
Date:   Fri Jun 27 17:19:22 2014 +0200

    drm/fb-helper: Fix hpd vs. initial config races

Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Mika Kuoppala <mika.kuoppala@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/20170706130023.28417-1-daniel.vetter@ffwll.ch
drivers/gpu/drm/i915/intel_fbdev.c

index 0c4cde6b2e6fc7aad314e7c7f329f51f0937a87d..ee1a5b937590696c1087644959ae476391a71484 100644 (file)
@@ -813,7 +813,7 @@ void intel_fbdev_output_poll_changed(struct drm_device *dev)
 {
        struct intel_fbdev *ifbdev = to_i915(dev)->fbdev;
 
-       if (ifbdev && ifbdev->vma)
+       if (ifbdev)
                drm_fb_helper_hotplug_event(&ifbdev->helper);
 }