ASoC: simple-card: fix regression in clock rate lookup
authorArnd Bergmann <arnd@arndb.de>
Mon, 8 Sep 2014 11:14:05 +0000 (13:14 +0200)
committerMark Brown <broonie@kernel.org>
Wed, 10 Sep 2014 10:56:42 +0000 (11:56 +0100)
Commit 7c7b9cf53d284f ("ASoC: simple-card: fixup cpu_dai_name
clear case") changed the way that "sound-dai" properties are handled,
which leads to the clock frequency not being picked up from the
node that the phandle points to, as correctly identified by gcc
with this warning:

sound/soc/generic/simple-card.c: In function 'asoc_simple_card_sub_parse_of':
sound/soc/generic/simple-card.c:165:7: warning: 'node' may be used uninitialized in this function [-Wmaybe-uninitialized]

This restores the previous behavior by using the node from
of_parse_phandle_with_args() that was previously being
returned from of_parse_phandle().

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/generic/simple-card.c

index f79347c4c62f9bd220f931d1cc000d0eab2eff1d..106fdada86400683b566ce24e0609f1a1f1e455f 100644 (file)
@@ -116,7 +116,6 @@ asoc_simple_card_sub_parse_of(struct device_node *np,
                              int *args_count)
 {
        struct of_phandle_args args;
-       struct device_node *node;
        struct clk *clk;
        u32 val;
        int ret;
@@ -162,7 +161,7 @@ asoc_simple_card_sub_parse_of(struct device_node *np,
        } else if (!of_property_read_u32(np, "system-clock-frequency", &val)) {
                dai->sysclk = val;
        } else {
-               clk = of_clk_get(node, 0);
+               clk = of_clk_get(args.np, 0);
                if (!IS_ERR(clk))
                        dai->sysclk = clk_get_rate(clk);
        }