arm64: capabilities: Rework EL2 vector hardening entry
authorMarc Zyngier <marc.zyngier@arm.com>
Tue, 10 Apr 2018 10:36:43 +0000 (11:36 +0100)
committerWill Deacon <will.deacon@arm.com>
Wed, 11 Apr 2018 17:49:30 +0000 (18:49 +0100)
Since 5e7951ce19ab ("arm64: capabilities: Clean up midr range helpers"),
capabilities must be represented with a single entry. If multiple
CPU types can use the same capability, then they need to be enumerated
in a list.

The EL2 hardening stuff (which affects both A57 and A72) managed to
escape the conversion in the above patch thanks to the 4.17 merge
window. Let's fix it now.

Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
Signed-off-by: Will Deacon <will.deacon@arm.com>
arch/arm64/kernel/cpu_errata.c

index 103c53fb0b4d4302bd8a78f0045362bb61604ffd..4e9f6a36d5e6f69f7315de365a7439ece044211d 100644 (file)
@@ -324,8 +324,14 @@ static const struct midr_range arm64_bp_harden_smccc_cpus[] = {
 
 #endif
 
-#ifndef ERRATA_MIDR_ALL_VERSIONS
-#define        ERRATA_MIDR_ALL_VERSIONS(x)     MIDR_ALL_VERSIONS(x)
+#ifdef CONFIG_HARDEN_EL2_VECTORS
+
+static const struct midr_range arm64_harden_el2_vectors[] = {
+       MIDR_ALL_VERSIONS(MIDR_CORTEX_A57),
+       MIDR_ALL_VERSIONS(MIDR_CORTEX_A72),
+       {},
+};
+
 #endif
 
 const struct arm64_cpu_capabilities arm64_errata[] = {
@@ -478,14 +484,10 @@ const struct arm64_cpu_capabilities arm64_errata[] = {
 #endif
 #ifdef CONFIG_HARDEN_EL2_VECTORS
        {
-               .desc = "Cortex-A57 EL2 vector hardening",
+               .desc = "EL2 vector hardening",
                .capability = ARM64_HARDEN_EL2_VECTORS,
-               ERRATA_MIDR_ALL_VERSIONS(MIDR_CORTEX_A57),
-       },
-       {
-               .desc = "Cortex-A72 EL2 vector hardening",
-               .capability = ARM64_HARDEN_EL2_VECTORS,
-               ERRATA_MIDR_ALL_VERSIONS(MIDR_CORTEX_A72),
+               .type = ARM64_CPUCAP_LOCAL_CPU_ERRATUM,
+               ERRATA_MIDR_RANGE_LIST(arm64_harden_el2_vectors),
        },
 #endif
        {