staging/xgifb: Remove unused values in XG27_SR13 and XGI340_SR13
authorPeter Huewe <peterhuewe@gmx.de>
Tue, 5 Feb 2013 21:32:30 +0000 (22:32 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 5 Feb 2013 21:45:09 +0000 (13:45 -0800)
 In the lookup tables XG27_SR13 and XGI340_SR13 only the first three
 values are used of each 'line', thus the remaining fields can be
 removed.

Rationale:
- vb_init.c uses pVBInfo->ram_type for the 'column' index for
pVBInfo->SR15.

- pVBInfo->ram_type is assigned the return value of
XGINew_GetXG20DRAMType which can only be 0, 1 or 2

- pVBInfo->SR15 is assigned to either XG27_SR13 or XGI340_SR13 in
vb_setmode.c

-> only the first three values are used.
This becomes also evident as values 3-7 are all 0.

Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/xgifb/vb_struct.h
drivers/staging/xgifb/vb_table.h

index 02f3bb5e09cee026e5dc1060e20cfe0727cfe142..ae0c18b320a48cb97d4ae219a4d59cb7ceb22e38 100644 (file)
@@ -157,7 +157,7 @@ struct vb_device_info {
 
        void __iomem *FBAddr;
 
-       unsigned char const (*SR15)[8];
+       unsigned char const (*SR15)[3];
        unsigned char const (*CR40)[3];
 
        struct SiS_MCLKData const *MCLKData;
index a1be75199e3d0c1c8c1e0b39e457a9d4d92730aa..b7abe25f3a4aef5dd11fee0468bab6db7647647f 100644 (file)
@@ -33,18 +33,18 @@ const struct XGI_ECLKDataStruct XGI340_ECLKData[] = {
        {0x5c, 0x23, 0x01, 166}
 };
 
-static const unsigned char XG27_SR13[4][8] = {
-       {0x35, 0x45, 0xb1, 0x00, 0x00, 0x00, 0x00, 0x00}, /* SR13 */
-       {0x41, 0x51, 0x5c, 0x00, 0x00, 0x00, 0x00, 0x00}, /* SR14 */
-       {0x32, 0x32, 0x42, 0x00, 0x00, 0x00, 0x00, 0x00}, /* SR18 */
-       {0x03, 0x03, 0x03, 0x00, 0x00, 0x00, 0x00, 0x00}  /* SR1B */
-};
-
-static const unsigned char XGI340_SR13[4][8] = {
-       {0x35, 0x45, 0xb1, 0x00, 0x00, 0x00, 0x00, 0x00}, /* SR13 */
-       {0x41, 0x51, 0x5c, 0x00, 0x00, 0x00, 0x00, 0x00}, /* SR14 */
-       {0x31, 0x42, 0x42, 0x00, 0x00, 0x00, 0x00, 0x00}, /* SR18 */
-       {0x03, 0x03, 0x03, 0x00, 0x00, 0x00, 0x00, 0x00}  /* SR1B */
+static const unsigned char XG27_SR13[4][3] = {
+       {0x35, 0x45, 0xb1}, /* SR13 */
+       {0x41, 0x51, 0x5c}, /* SR14 */
+       {0x32, 0x32, 0x42}, /* SR18 */
+       {0x03, 0x03, 0x03}  /* SR1B */
+};
+
+static const unsigned char XGI340_SR13[4][3] = {
+       {0x35, 0x45, 0xb1}, /* SR13 */
+       {0x41, 0x51, 0x5c}, /* SR14 */
+       {0x31, 0x42, 0x42}, /* SR18 */
+       {0x03, 0x03, 0x03}  /* SR1B */
 };
 
 static const unsigned char XGI340_cr41[24][3] = {