Input: synaptics-rmi4 - re-enable IRQs in f34v7_do_reflash
authorLucas Stach <l.stach@pengutronix.de>
Mon, 2 Dec 2019 17:37:00 +0000 (09:37 -0800)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Thu, 5 Dec 2019 01:58:16 +0000 (17:58 -0800)
F34 is a bit special as it reinitializes the device and related driver
structs during the firmware update. This clears the fn_irq_mask which
will then prevent F34 from receiving further interrupts, leading to
timeouts during the firmware update. Make sure to reinitialize the
IRQ enables at the appropriate times.

The issue is in F34 code, but the commit in the fixes tag exposed the
issue, as before this commit things would work by accident.

Fixes: 363c53875aef (Input: synaptics-rmi4 - avoid processing unknown IRQs)
Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
Link: https://lore.kernel.org/r/20191129133514.23224-1-l.stach@pengutronix.de
Cc: stable@vger.kernel.org
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/rmi4/rmi_f34v7.c

index a4cabf52740c206236c099d1909d12ca624348b1..74f7c6f214ff5414af7c738e29e87acc2539fafa 100644 (file)
@@ -1189,6 +1189,9 @@ int rmi_f34v7_do_reflash(struct f34_data *f34, const struct firmware *fw)
 {
        int ret;
 
+       f34->fn->rmi_dev->driver->set_irq_bits(f34->fn->rmi_dev,
+                                              f34->fn->irq_mask);
+
        rmi_f34v7_read_queries_bl_version(f34);
 
        f34->v7.image = fw->data;