IB/qib: Remove qpt_mask global
authorDennis Dalessandro <dennis.dalessandro@intel.com>
Sun, 25 Sep 2016 14:41:05 +0000 (07:41 -0700)
committerDoug Ledford <dledford@redhat.com>
Sun, 2 Oct 2016 12:42:11 +0000 (08:42 -0400)
There is no need to have a global qpt_mask as that does not support the
multiple chip model which qib has. Instead rely on the value which
exists already in the device data (dd).

Fixes: 898fa52b4ac3 "IB/qib: Remove qpn, qp tables and related variables from qib"
Reviewed-by: Mike Marciniszyn <mike.marciniszyn@intel.com>
Signed-off-by: Dennis Dalessandro <dennis.dalessandro@intel.com>
Signed-off-by: Doug Ledford <dledford@redhat.com>
drivers/infiniband/hw/qib/qib.h
drivers/infiniband/hw/qib/qib_qp.c
drivers/infiniband/hw/qib/qib_verbs.c

index bebc9a5d80cdefb198448c71d10c4e8da26de9d5..a3e21a25cea5b38c1723ebbafec21be0ea1c69fa 100644 (file)
@@ -1132,7 +1132,6 @@ extern spinlock_t qib_devs_lock;
 extern struct qib_devdata *qib_lookup(int unit);
 extern u32 qib_cpulist_count;
 extern unsigned long *qib_cpulist;
-extern u16 qpt_mask;
 extern unsigned qib_cc_table_size;
 
 int qib_init(struct qib_devdata *, int);
index f9b8cd2354d1ba6f6b077aea249f00b2f3a8e8bb..99d31efe4c2f9c46d555e60530052510f078a3da 100644 (file)
 
 #include "qib.h"
 
-/*
- * mask field which was present in now deleted qib_qpn_table
- * is not present in rvt_qpn_table. Defining the same field
- * as qpt_mask here instead of adding the mask field to
- * rvt_qpn_table.
- */
-u16 qpt_mask;
-
 static inline unsigned mk_qpn(struct rvt_qpn_table *qpt,
                              struct rvt_qpn_map *map, unsigned off)
 {
@@ -57,7 +49,7 @@ static inline unsigned mk_qpn(struct rvt_qpn_table *qpt,
 
 static inline unsigned find_next_offset(struct rvt_qpn_table *qpt,
                                        struct rvt_qpn_map *map, unsigned off,
-                                       unsigned n)
+                                       unsigned n, u16 qpt_mask)
 {
        if (qpt_mask) {
                off++;
@@ -179,6 +171,7 @@ int qib_alloc_qpn(struct rvt_dev_info *rdi, struct rvt_qpn_table *qpt,
        struct qib_ibdev *verbs_dev = container_of(rdi, struct qib_ibdev, rdi);
        struct qib_devdata *dd = container_of(verbs_dev, struct qib_devdata,
                                              verbs_dev);
+       u16 qpt_mask = dd->qpn_mask;
 
        if (type == IB_QPT_SMI || type == IB_QPT_GSI) {
                unsigned n;
@@ -215,7 +208,7 @@ int qib_alloc_qpn(struct rvt_dev_info *rdi, struct rvt_qpn_table *qpt,
                                goto bail;
                        }
                        offset = find_next_offset(qpt, map, offset,
-                               dd->n_krcv_queues);
+                               dd->n_krcv_queues, qpt_mask);
                        qpn = mk_qpn(qpt, map, offset);
                        /*
                         * This test differs from alloc_pidmap().
index c12ec8f4b9ced1ceead3d7812db4074864de6a61..876ebb442d3806d555d662805ee2ee4c01eda544 100644 (file)
@@ -1606,8 +1606,6 @@ int qib_register_ib_device(struct qib_devdata *dd)
        /* Only need to initialize non-zero fields. */
        setup_timer(&dev->mem_timer, mem_timer, (unsigned long)dev);
 
-       qpt_mask = dd->qpn_mask;
-
        INIT_LIST_HEAD(&dev->piowait);
        INIT_LIST_HEAD(&dev->dmawait);
        INIT_LIST_HEAD(&dev->txwait);