platform: goldfish: pipe: Update the comment for GFP_ATOMIC
authorRoman Kiryanov <rkir@google.com>
Mon, 27 Aug 2018 18:23:00 +0000 (11:23 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 14 Sep 2018 13:31:30 +0000 (15:31 +0200)
Provide an explanation why GFP_ATOMIC is needed to prevent changing it to
other values.

Signed-off-by: Roman Kiryanov <rkir@google.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/platform/goldfish/goldfish_pipe.c

index caf514aafb211e98ae37691088804975fed06bbc..0c55e657da5a507d13c8992a72f435ca9e5d2819 100644 (file)
@@ -640,7 +640,10 @@ static int get_free_pipe_id_locked(struct goldfish_pipe_dev *dev)
                        return id;
 
        {
-               /* Reallocate the array */
+               /* Reallocate the array.
+                * Since get_free_pipe_id_locked runs with interrupts disabled,
+                * we don't want to make calls that could lead to sleep.
+                */
                u32 new_capacity = 2 * dev->pipes_capacity;
                struct goldfish_pipe **pipes =
                        kcalloc(new_capacity, sizeof(*pipes), GFP_ATOMIC);