projects
/
openwrt
/
staging
/
blogic.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
097933d
)
isdn/gigaset: fix NULL pointer dereference
author
Tilman Schmidt
<tilman@imap.cc>
Sat, 11 Oct 2014 11:46:29 +0000
(13:46 +0200)
committer
David S. Miller
<davem@davemloft.net>
Tue, 14 Oct 2014 19:05:33 +0000
(15:05 -0400)
In do_action, a NULL pointer might be passed to function start_dial
which will dereference it.
Fix by adding a check for NULL before the call.
Spotted with Coverity.
Signed-off-by: Tilman Schmidt <tilman@imap.cc>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/isdn/gigaset/ev-layer.c
patch
|
blob
|
history
diff --git
a/drivers/isdn/gigaset/ev-layer.c
b/drivers/isdn/gigaset/ev-layer.c
index dcae14aef3763cd416c2f6e3d807d44e7c5b4624..0f699ebd81c5361e9d3226c09e5ef651df061230 100644
(file)
--- a/
drivers/isdn/gigaset/ev-layer.c
+++ b/
drivers/isdn/gigaset/ev-layer.c
@@
-1380,6
+1380,11
@@
static void do_action(int action, struct cardstate *cs,
/* events from the LL */
case ACT_DIAL:
+ if (!ev->ptr) {
+ *p_genresp = 1;
+ *p_resp_code = RSP_ERROR;
+ break;
+ }
start_dial(at_state, ev->ptr, ev->parameter);
break;
case ACT_ACCEPT: