drm/amd/powerplay: notify smu once display changed on Rv.

when User turn off display or screen idle timeout,
smu need this message to start S0i2 entry.

Signed-off-by: Rex Zhu <Rex.Zhu@amd.com>
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/hardwaremanager.c b/drivers/gpu/drm/amd/powerplay/hwmgr/hardwaremanager.c
index fcc722ea76490a3d788c1a2b577423dd01033392..967f50f54384d4a560a133ba6822168c5ed42006 100644 (file)
--- a/drivers/gpu/drm/amd/powerplay/hwmgr/hardwaremanager.c
+++ b/drivers/gpu/drm/amd/powerplay/hwmgr/hardwaremanager.c
@@ -323,6 +323,9 @@ int phm_check_states_equal(struct pp_hwmgr *hwmgr,
 int phm_store_dal_configuration_data(struct pp_hwmgr *hwmgr,
                    const struct amd_pp_display_configuration *display_config)
 {
+       int index = 0;
+       int number_of_active_display = 0;
+
        PHM_FUNC_CHECK(hwmgr);
 
        if (display_config == NULL)
@@ -330,6 +333,17 @@ int phm_store_dal_configuration_data(struct pp_hwmgr *hwmgr,
 
        hwmgr->display_config = *display_config;
 
+       if (NULL != hwmgr->hwmgr_func->set_deep_sleep_dcefclk)
+               hwmgr->hwmgr_func->set_deep_sleep_dcefclk(hwmgr, hwmgr->display_config.min_dcef_deep_sleep_set_clk);
+
+       for (index = 0; index < hwmgr->display_config.num_path_including_non_display; index++) {
+               if (hwmgr->display_config.displays[index].controller_id != 0)
+                       number_of_active_display++;
+       }
+
+       if (NULL != hwmgr->hwmgr_func->set_active_display_count)
+               hwmgr->hwmgr_func->set_active_display_count(hwmgr, number_of_active_display);
+
        if (hwmgr->hwmgr_func->store_cc6_data == NULL)
                return -EINVAL;
 

diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/rv_hwmgr.c b/drivers/gpu/drm/amd/powerplay/hwmgr/rv_hwmgr.c
index 3e443c11f47b9a10b8e6cc921d4ef17b00ff1e3b..441a916ba3d65d60e4ef52e292f58ff757e3a59d 100644 (file)
--- a/drivers/gpu/drm/amd/powerplay/hwmgr/rv_hwmgr.c
+++ b/drivers/gpu/drm/amd/powerplay/hwmgr/rv_hwmgr.c
@@ -76,6 +76,9 @@ static int rv_initialize_dpm_defaults(struct pp_hwmgr *hwmgr)
        rv_hwmgr->is_nb_dpm_enabled = 1;
        rv_hwmgr->dpm_flags = 1;
        rv_hwmgr->gfx_off_controled_by_driver = false;
+       rv_hwmgr->need_min_deep_sleep_dcefclk = true;
+       rv_hwmgr->num_active_display = 0;
+       rv_hwmgr->deep_sleep_dcefclk = 0;
 
        phm_cap_unset(hwmgr->platform_descriptor.platformCaps,
                                        PHM_PlatformCaps_SclkDeepSleep);
@@ -162,21 +165,12 @@ static int rv_tf_set_clock_limit(struct pp_hwmgr *hwmgr, void *input,
        struct pp_display_clock_request clock_req;
 
        clocks.dcefClock = hwmgr->display_config.min_dcef_set_clk;
-       clocks.dcefClockInSR = hwmgr->display_config.min_dcef_deep_sleep_set_clk;
        clock_req.clock_type = amd_pp_dcf_clock;
        clock_req.clock_freq_in_khz = clocks.dcefClock * 10;
 
-       if (clocks.dcefClock == 0 && clocks.dcefClockInSR == 0)
-               clock_req.clock_freq_in_khz = rv_data->dcf_actual_hard_min_freq;
-
        PP_ASSERT_WITH_CODE(!rv_display_clock_voltage_request(hwmgr, &clock_req),
                                "Attempt to set DCF Clock Failed!", return -EINVAL);
 
-       if(rv_data->need_min_deep_sleep_dcefclk && 0 != clocks.dcefClockInSR)
-               smum_send_msg_to_smc_with_parameter(hwmgr->smumgr,
-                                       PPSMC_MSG_SetMinDeepSleepDcefclk,
-                                       clocks.dcefClockInSR / 100);
-
        if (((hwmgr->uvd_arbiter.vclk_soft_min / 100) != rv_data->vclk_soft_min) ||
            ((hwmgr->uvd_arbiter.dclk_soft_min / 100) != rv_data->dclk_soft_min)) {
                rv_data->vclk_soft_min = hwmgr->uvd_arbiter.vclk_soft_min / 100;
@@ -213,26 +207,35 @@ static int rv_tf_set_clock_limit(struct pp_hwmgr *hwmgr, void *input,
        return 0;
 }
 
-
-static int rv_tf_set_num_active_display(struct pp_hwmgr *hwmgr, void *input,
-                               void *output, void *storage, int result)
+static int rv_set_deep_sleep_dcefclk(struct pp_hwmgr *hwmgr, uint32_t clock)
 {
-       uint32_t  num_of_active_displays = 0;
-       struct cgs_display_info info = {0};
+       struct rv_hwmgr *rv_data = (struct rv_hwmgr *)(hwmgr->backend);
 
-       cgs_get_active_displays_info(hwmgr->device, &info);
-       num_of_active_displays = info.display_count;
+       if (rv_data->need_min_deep_sleep_dcefclk && rv_data->deep_sleep_dcefclk != clock/100) {
+               rv_data->deep_sleep_dcefclk = clock/100;
+               smum_send_msg_to_smc_with_parameter(hwmgr->smumgr,
+                                       PPSMC_MSG_SetMinDeepSleepDcefclk,
+                                       rv_data->deep_sleep_dcefclk);
+       }
+       return 0;
+}
+
+static int rv_set_active_display_count(struct pp_hwmgr *hwmgr, uint32_t count)
+{
+       struct rv_hwmgr *rv_data = (struct rv_hwmgr *)(hwmgr->backend);
 
-       smum_send_msg_to_smc_with_parameter(hwmgr->smumgr,
+       if (rv_data->num_active_display != count) {
+               rv_data->num_active_display = count;
+               smum_send_msg_to_smc_with_parameter(hwmgr->smumgr,
                                PPSMC_MSG_SetDisplayCount,
-                               num_of_active_displays);
+                               rv_data->num_active_display);
+       }
 
        return 0;
 }
 
 static const struct phm_master_table_item rv_set_power_state_list[] = {
        { NULL, rv_tf_set_clock_limit },
-       { NULL, rv_tf_set_num_active_display },
        { }
 };
 
@@ -955,6 +958,8 @@ static const struct pp_hwmgr_func rv_hwmgr_funcs = {
        .get_clock_by_type_with_voltage = rv_get_clock_by_type_with_voltage,
        .get_max_high_clocks = rv_get_max_high_clocks,
        .read_sensor = rv_read_sensor,
+       .set_active_display_count = rv_set_active_display_count,
+       .set_deep_sleep_dcefclk = rv_set_deep_sleep_dcefclk,
 };
 
 int rv_init_function_pointers(struct pp_hwmgr *hwmgr)

diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/rv_hwmgr.h b/drivers/gpu/drm/amd/powerplay/hwmgr/rv_hwmgr.h
index 2472b50e54cfb67730176b47676c0ca1cc9f5163..68d61bd95ca00794a2fa7c20dcce61e9a1a0ac81 100644 (file)
--- a/drivers/gpu/drm/amd/powerplay/hwmgr/rv_hwmgr.h
+++ b/drivers/gpu/drm/amd/powerplay/hwmgr/rv_hwmgr.h
@@ -293,7 +293,9 @@ struct rv_hwmgr {
        DpmClocks_t                       clock_table;
 
        uint32_t active_process_mask;
-       bool need_min_deep_sleep_dcefclk; /* disabled by default */
+       bool need_min_deep_sleep_dcefclk;
+       uint32_t                             deep_sleep_dcefclk;
+       uint32_t                             num_active_display;
 };
 
 struct pp_hwmgr;

diff --git a/drivers/gpu/drm/amd/powerplay/inc/hwmgr.h b/drivers/gpu/drm/amd/powerplay/inc/hwmgr.h
index 91b0105e82403c448cee8a6c303828f392e87eb8..b1a6372608de7c07de14c4b00462eb034b39fe9a 100644 (file)
--- a/drivers/gpu/drm/amd/powerplay/inc/hwmgr.h
+++ b/drivers/gpu/drm/amd/powerplay/inc/hwmgr.h
@@ -378,6 +378,8 @@ struct pp_hwmgr_func {
                        struct amd_pp_profile *request);
        int (*avfs_control)(struct pp_hwmgr *hwmgr, bool enable);
        int (*disable_smc_firmware_ctf)(struct pp_hwmgr *hwmgr);
+       int (*set_active_display_count)(struct pp_hwmgr *hwmgr, uint32_t count);
+       int (*set_deep_sleep_dcefclk)(struct pp_hwmgr *hwmgr, uint32_t clock);
 };
 
 struct pp_table_func {