compat_hdio_ioctl: Fix a declaration
authorBart Van Assche <bart.vanassche@wdc.com>
Wed, 23 Aug 2017 22:29:11 +0000 (15:29 -0700)
committerAl Viro <viro@zeniv.linux.org.uk>
Thu, 31 Aug 2017 21:32:41 +0000 (17:32 -0400)
This patch avoids that sparse reports the following warning messages:

block/compat_ioctl.c:85:11: warning: incorrect type in assignment (different address spaces)
block/compat_ioctl.c:85:11:    expected unsigned long *[noderef] <asn:1>p
block/compat_ioctl.c:85:11:    got void [noderef] <asn:1>*
block/compat_ioctl.c:91:21: warning: incorrect type in argument 1 (different address spaces)
block/compat_ioctl.c:91:21:    expected void const volatile [noderef] <asn:1>*<noident>
block/compat_ioctl.c:91:21:    got unsigned long *[noderef] <asn:1>p
block/compat_ioctl.c:87:53: warning: dereference of noderef expression
block/compat_ioctl.c:91:21: warning: dereference of noderef expression

Fixes: commit d597580d3737 ("generic ...copy_..._user primitives")
Signed-off-by: Bart Van Assche <bart.vanassche@wdc.com>
Cc: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
block/compat_ioctl.c

index 38554c2ea38adc28f0835b35f65cdb2c94451656..abaf9d78a2061d8d307a3f05858afbc8445c15d7 100644 (file)
@@ -79,7 +79,7 @@ static int compat_hdio_getgeo(struct gendisk *disk, struct block_device *bdev,
 static int compat_hdio_ioctl(struct block_device *bdev, fmode_t mode,
                unsigned int cmd, unsigned long arg)
 {
-       unsigned long *__user p;
+       unsigned long __user *p;
        int error;
 
        p = compat_alloc_user_space(sizeof(unsigned long));