perf trace: Use strtoul for the fcntl 'cmd' argument
authorArnaldo Carvalho de Melo <acme@redhat.com>
Fri, 18 Oct 2019 18:44:42 +0000 (15:44 -0300)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Sat, 19 Oct 2019 18:35:02 +0000 (15:35 -0300)
Since its values are in two ranges of values we ended up codifying it
using a 'struct strarrays', so now hook it up with STUL_STRARRAYS so
that we can do:

  # perf trace -e syscalls:*enter_fcntl --filter=cmd==SETLK||cmd==SETLKW
     0.000 sssd_kcm/19021 syscalls:sys_enter_fcntl(fd: 13</var/lib/sss/secrets/secrets.ldb>, cmd: SETLK, arg: 0x7ffcf0a4dee0)
     1.523 sssd_kcm/19021 syscalls:sys_enter_fcntl(fd: 13</var/lib/sss/secrets/secrets.ldb>, cmd: SETLK, arg: 0x7ffcf0a4de90)
     1.629 sssd_kcm/19021 syscalls:sys_enter_fcntl(fd: 13</var/lib/sss/secrets/secrets.ldb>, cmd: SETLK, arg: 0x7ffcf0a4de90)
     2.711 sssd_kcm/19021 syscalls:sys_enter_fcntl(fd: 13</var/lib/sss/secrets/secrets.ldb>, cmd: SETLK, arg: 0x7ffcf0a4de70)
  ^C#

Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: Brendan Gregg <brendan.d.gregg@gmail.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Luis Cláudio Gonçalves <lclaudio@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Link: https://lkml.kernel.org/n/tip-mob96wyzri4r3rvyigqfjv0a@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/builtin-trace.c

index 265ea876f00b8306db6e0eb09570ab47c812b283..72ef3b39550480815f54840a96af3475b6080193 100644 (file)
@@ -894,7 +894,8 @@ static struct syscall_fmt syscall_fmts[] = {
        { .name     = "fchownat",
          .arg = { [0] = { .scnprintf = SCA_FDAT, /* fd */ }, }, },
        { .name     = "fcntl",
-         .arg = { [1] = { .scnprintf = SCA_FCNTL_CMD, /* cmd */
+         .arg = { [1] = { .scnprintf = SCA_FCNTL_CMD,  /* cmd */
+                          .strtoul   = STUL_STRARRAYS,
                           .parm      = &strarrays__fcntl_cmds_arrays,
                           .show_zero = true, },
                   [2] = { .scnprintf =  SCA_FCNTL_ARG, /* arg */ }, }, },