clk: qcom: clk-smd-rpm: Fix clk_hw references

Fix the clk_hw references to the actual clocks and add a xlate function
to return the hw pointers from the already existing static array.

Reported-by: Michael Scott <michael.scott@linaro.org>
Signed-off-by: Georgi Djakov <georgi.djakov@linaro.org>
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>

diff --git a/drivers/clk/qcom/clk-smd-rpm.c b/drivers/clk/qcom/clk-smd-rpm.c
index a27013dbc0aad26ca34ad60f0d30167be754129a..07e2cc6ed7813fb8c59b64b01090efdff626827b 100644 (file)
--- a/drivers/clk/qcom/clk-smd-rpm.c
+++ b/drivers/clk/qcom/clk-smd-rpm.c
@@ -148,8 +148,8 @@ struct clk_smd_rpm_req {
 
 struct rpm_cc {
        struct qcom_rpm *rpm;
-       struct clk_hw_onecell_data data;
-       struct clk_hw *hws[];
+       struct clk_smd_rpm **clks;
+       size_t num_clks;
 };
 
 struct rpm_smd_clk_desc {
@@ -468,11 +468,23 @@ static const struct of_device_id rpm_smd_clk_match_table[] = {
 };
 MODULE_DEVICE_TABLE(of, rpm_smd_clk_match_table);
 
+static struct clk_hw *qcom_smdrpm_clk_hw_get(struct of_phandle_args *clkspec,
+                                            void *data)
+{
+       struct rpm_cc *rcc = data;
+       unsigned int idx = clkspec->args[0];
+
+       if (idx >= rcc->num_clks) {
+               pr_err("%s: invalid index %u\n", __func__, idx);
+               return ERR_PTR(-EINVAL);
+       }
+
+       return rcc->clks[idx] ? &rcc->clks[idx]->hw : ERR_PTR(-ENOENT);
+}
+
 static int rpm_smd_clk_probe(struct platform_device *pdev)
 {
-       struct clk_hw **hws;
        struct rpm_cc *rcc;
-       struct clk_hw_onecell_data *data;
        int ret;
        size_t num_clks, i;
        struct qcom_smd_rpm *rpm;
@@ -492,14 +504,12 @@ static int rpm_smd_clk_probe(struct platform_device *pdev)
        rpm_smd_clks = desc->clks;
        num_clks = desc->num_clks;
 
-       rcc = devm_kzalloc(&pdev->dev, sizeof(*rcc) + sizeof(*hws) * num_clks,
-                          GFP_KERNEL);
+       rcc = devm_kzalloc(&pdev->dev, sizeof(*rcc), GFP_KERNEL);
        if (!rcc)
                return -ENOMEM;
 
-       hws = rcc->hws;
-       data = &rcc->data;
-       data->num = num_clks;
+       rcc->clks = rpm_smd_clks;
+       rcc->num_clks = num_clks;
 
        for (i = 0; i < num_clks; i++) {
                if (!rpm_smd_clks[i])
@@ -517,18 +527,16 @@ static int rpm_smd_clk_probe(struct platform_device *pdev)
                goto err;
 
        for (i = 0; i < num_clks; i++) {
-               if (!rpm_smd_clks[i]) {
-                       data->hws[i] = ERR_PTR(-ENOENT);
+               if (!rpm_smd_clks[i])
                        continue;
-               }
 
                ret = devm_clk_hw_register(&pdev->dev, &rpm_smd_clks[i]->hw);
                if (ret)
                        goto err;
        }
 
-       ret = of_clk_add_hw_provider(pdev->dev.of_node, of_clk_hw_onecell_get,
-                                    data);
+       ret = of_clk_add_hw_provider(pdev->dev.of_node, qcom_smdrpm_clk_hw_get,
+                                    rcc);
        if (ret)
                goto err;