drm/i915: Add a reminder that i915_vma_move_to_active() requires struct_mutex
authorChris Wilson <chris@chris-wilson.co.uk>
Sun, 18 Dec 2016 15:37:18 +0000 (15:37 +0000)
committerChris Wilson <chris@chris-wilson.co.uk>
Sun, 18 Dec 2016 16:18:48 +0000 (16:18 +0000)
i915_vma_move_to_active() requires the struct_mutex for serialisation
with retirement, so mark it up with lockdep_assert_held().

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/20161218153724.8439-1-chris@chris-wilson.co.uk
drivers/gpu/drm/i915/i915_gem_execbuffer.c

index d665a33229bd93575363277503d4eac3005e7f98..c64438f8171ccf02ff9009199690e119d6354f3e 100644 (file)
@@ -1259,6 +1259,7 @@ void i915_vma_move_to_active(struct i915_vma *vma,
        struct drm_i915_gem_object *obj = vma->obj;
        const unsigned int idx = req->engine->id;
 
+       lockdep_assert_held(&req->i915->drm.struct_mutex);
        GEM_BUG_ON(!drm_mm_node_allocated(&vma->node));
 
        /* Add a reference if we're newly entering the active list.