media: venus: vdec: Fix forgotten mutex unlock in start streaming
authorStanimir Varbanov <stanimir.varbanov@linaro.org>
Tue, 3 Mar 2020 11:15:32 +0000 (12:15 +0100)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Thu, 12 Mar 2020 10:50:20 +0000 (11:50 +0100)
This fixes the following smatch warning in the error path:

drivers/media/platform/qcom/venus/vdec.c:968 vdec_start_streaming()
 warn: inconsistent returns 'mutex:&inst->lock'.
  Locked on:   line 952
  Unlocked on: line 963
               line 968

by goto mutex unlock.

Signed-off-by: Stanimir Varbanov <stanimir.varbanov@linaro.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/platform/qcom/venus/vdec.c

index f349201c0f0da1fb31ec09ef6f2d4c36462e9bbe..4ed2628585a1165e83289f65903e9ee5bd858df4 100644 (file)
@@ -949,7 +949,7 @@ static int vdec_start_streaming(struct vb2_queue *q, unsigned int count)
 
        ret = venus_pm_acquire_core(inst);
        if (ret)
-               return ret;
+               goto error;
 
        if (q->type == V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE)
                ret = vdec_start_capture(inst);