Simplify test for RAM devices
authorJörn Engel <joern@wohnheim.fh-wedel.de>
Thu, 13 Apr 2006 16:53:14 +0000 (18:53 +0200)
committerDavid Woodhouse <dwmw2@infradead.org>
Mon, 17 Apr 2006 14:48:16 +0000 (15:48 +0100)
mtdblock is the only user of aggregate capabilities in mtd.  This is clearly
bogus and should be changed.  In particular, it tries to determine whether
the device in question is a piece of RAM.  For every single driver that fits
the current criteria, an easier test would be to check for the type being
MTD_RAM.

Signed-off-by: Jörn Engel <joern@wohnheim.fh-wedel.de>
Signed-off-by: David Woodhouse <dwmw2@infradead.org>
drivers/mtd/mtdblock.c

index 2cef280e388c76aaf455fe49f3232596f8d40308..8e50170137e003f3ff35504dc0634646d36bcb52 100644 (file)
@@ -288,8 +288,7 @@ static int mtdblock_open(struct mtd_blktrans_dev *mbd)
 
        mutex_init(&mtdblk->cache_mutex);
        mtdblk->cache_state = STATE_EMPTY;
-       if ((mtdblk->mtd->flags & MTD_CAP_RAM) != MTD_CAP_RAM &&
-           mtdblk->mtd->erasesize) {
+       if (mtdblk->mtd->type != MTD_RAM && mtdblk->mtd->erasesize) {
                mtdblk->cache_size = mtdblk->mtd->erasesize;
                mtdblk->cache_data = NULL;
        }