generic: phy: aquantia: fix MDI pair property parsing
authorRobert Marko <robimarko@gmail.com>
Mon, 23 Sep 2024 16:16:51 +0000 (18:16 +0200)
committerRobert Marko <robimarko@gmail.com>
Mon, 23 Sep 2024 16:38:44 +0000 (18:38 +0200)
of_property_read_u32 returns -EINVAL when property does not exist,
according to the documentation -ENOENT is not a valid return code.

So, instead of checking for -ENOENT check for -EINVAL as otherwise the
blamed commit breaks AQR probe since it will return -EINVAL during probe.

Fixes: cb2a11f49c98 ("generic: phy: aquantia: add pending patch to force MDI pair order")
Link: https://github.com/openwrt/openwrt/pull/16466
Signed-off-by: Robert Marko <robimarko@gmail.com>
target/linux/generic/pending-6.6/752-net-phy-aquantia-allow-forcing-order-of-MDI-pairs.patch

index 97e2953a5073e929e84c920e2dce939ebabbd058..f3ae893b32b99e85ee81a53fa5f31aca8b348e09 100644 (file)
@@ -74,7 +74,7 @@ Signed-off-by: Daniel Golle <daniel@makrotopia.org>
 +      ret = of_property_read_u32(np, "marvell,mdi-cfg-order", &mdi_conf);
 +
 +      /* Do nothing in case property "marvell,mdi-cfg-order" is not present */
-+      if (ret == -ENOENT)
++      if (ret == -EINVAL)
 +              return 0;
 +
 +      if (ret)