drm/tegra: dsi: Set up PHY_TIMING & BTA_TIMING registers earlier
authorSean Paul <seanpaul@chromium.org>
Tue, 7 Oct 2014 14:04:42 +0000 (16:04 +0200)
committerThierry Reding <treding@nvidia.com>
Thu, 13 Nov 2014 15:12:44 +0000 (16:12 +0100)
Make sure the DSI PHY_TIMING and BTA_TIMING registers are initialized
when the clocks are set up as opposed to when the output is enabled.
This makes sure that the PHY timings are properly set up when the panel
is prepared and that DCS commands sent at that time use the appropriate
timings.

Signed-off-by: Sean Paul <seanpaul@chromium.org>
Signed-off-by: Thierry Reding <treding@nvidia.com>
drivers/gpu/drm/tegra/dsi.c

index 8940360ccc9c4dca269d48c85abd581305eb8c88..33f67fd601c6076670496617d51366050f327238 100644 (file)
@@ -389,6 +389,9 @@ static int tegra_dsi_set_phy_timing(struct tegra_dsi *dsi)
                DSI_TIMING_FIELD(timing.tago, period, 1);
        tegra_dsi_writel(dsi, value, DSI_BTA_TIMING);
 
+       if (dsi->slave)
+               return tegra_dsi_set_phy_timing(dsi->slave);
+
        return 0;
 }
 
@@ -536,10 +539,6 @@ static int tegra_dsi_configure(struct tegra_dsi *dsi, unsigned int pipe,
        value &= ~DSI_CONTROL_HOST_ENABLE;
        tegra_dsi_writel(dsi, value, DSI_CONTROL);
 
-       err = tegra_dsi_set_phy_timing(dsi);
-       if (err < 0)
-               return err;
-
        for (i = 0; i < NUM_PKT_SEQ; i++)
                tegra_dsi_writel(dsi, pkt_seq[i], DSI_PKT_SEQ_0_LO + i);
 
@@ -860,6 +859,10 @@ static int tegra_output_dsi_setup_clock(struct tegra_output *output,
         */
        tegra_dsi_set_timeout(dsi, bclk, vrefresh);
 
+       err = tegra_dsi_set_phy_timing(dsi);
+       if (err < 0)
+               return err;
+
        return 0;
 }