ALSA: au88x0: Give comment for vortex_wtdma_bufshift() issue
authorTakashi Iwai <tiwai@suse.de>
Thu, 25 Oct 2012 11:55:51 +0000 (13:55 +0200)
committerTakashi Iwai <tiwai@suse.de>
Thu, 25 Oct 2012 11:55:51 +0000 (13:55 +0200)
The check of the return value from vortex_wtdma_bufshft() in
vortex_interrupt() is useless as it executes no code.  Actually the
return value is intentionally ignored because the delta calculation
for wavetable doesn't work always correctly.  For avoiding the
confusion, a comment is added and the superfluous if () is removed.

Reported-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/pci/au88x0/au88x0_core.c

index 525f881f04096bd25cec390d0a2a26443a93aa0c..2698abf5d05d5b1a7c5a82212905213526498821 100644 (file)
@@ -2461,7 +2461,12 @@ static irqreturn_t vortex_interrupt(int irq, void *dev_id)
 #ifndef CHIP_AU8810
                for (i = 0; i < NR_WT; i++) {
                        if (vortex->dma_wt[i].fifo_status == FIFO_START) {
-                               if (vortex_wtdma_bufshift(vortex, i)) ;
+                               /* FIXME: we ignore the return value from
+                                * vortex_wtdma_bufshift() below as the delta
+                                * calculation seems not working for wavetable
+                                * by some reason
+                                */
+                               vortex_wtdma_bufshift(vortex, i);
                                spin_unlock(&vortex->lock);
                                snd_pcm_period_elapsed(vortex->dma_wt[i].
                                                       substream);