net: qede: optional hw recovery procedure

Driver has an ability to initiate a recovery process as a reaction to
detected errors. But the codepath (recovery_process) was disabled and
never active.

Here we add ethtool private flag to allow user have the recovery
procedure activated.

We still do not enable this by default though, since in some configurations
this is not desirable. E.g. this may impact other PFs/VFs.

Signed-off-by: Ariel Elior <ariel.elior@marvell.com>
Signed-off-by: Michal Kalderon <michal.kalderon@marvell.com>
Signed-off-by: Igor Russkikh <irusskikh@marvell.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/drivers/net/ethernet/qlogic/qede/qede_ethtool.c b/drivers/net/ethernet/qlogic/qede/qede_ethtool.c
index 812c7766e09692c6a3be5fb3d1904ee424f7cfd5..24cc68391ac4ff2e41486b7bbc16d90cb2f85917 100644 (file)
--- a/drivers/net/ethernet/qlogic/qede/qede_ethtool.c
+++ b/drivers/net/ethernet/qlogic/qede/qede_ethtool.c
@@ -190,12 +190,14 @@ static const struct {
 enum {
        QEDE_PRI_FLAG_CMT,
        QEDE_PRI_FLAG_SMART_AN_SUPPORT, /* MFW supports SmartAN */
+       QEDE_PRI_FLAG_RECOVER_ON_ERROR,
        QEDE_PRI_FLAG_LEN,
 };
 
 static const char qede_private_arr[QEDE_PRI_FLAG_LEN][ETH_GSTRING_LEN] = {
        "Coupled-Function",
        "SmartAN capable",
+       "Recover on error",
 };
 
 enum qede_ethtool_tests {
@@ -417,9 +419,30 @@ static u32 qede_get_priv_flags(struct net_device *dev)
        if (edev->dev_info.common.smart_an)
                flags |= BIT(QEDE_PRI_FLAG_SMART_AN_SUPPORT);
 
+       if (edev->err_flags & BIT(QEDE_ERR_IS_RECOVERABLE))
+               flags |= BIT(QEDE_PRI_FLAG_RECOVER_ON_ERROR);
+
        return flags;
 }
 
+static int qede_set_priv_flags(struct net_device *dev, u32 flags)
+{
+       struct qede_dev *edev = netdev_priv(dev);
+       u32 cflags = qede_get_priv_flags(dev);
+       u32 dflags = flags ^ cflags;
+
+       /* can only change RECOVER_ON_ERROR flag */
+       if (dflags & ~BIT(QEDE_PRI_FLAG_RECOVER_ON_ERROR))
+               return -EINVAL;
+
+       if (flags & BIT(QEDE_PRI_FLAG_RECOVER_ON_ERROR))
+               set_bit(QEDE_ERR_IS_RECOVERABLE, &edev->err_flags);
+       else
+               clear_bit(QEDE_ERR_IS_RECOVERABLE, &edev->err_flags);
+
+       return 0;
+}
+
 struct qede_link_mode_mapping {
        u32 qed_link_mode;
        u32 ethtool_link_mode;
@@ -2098,6 +2121,7 @@ static const struct ethtool_ops qede_ethtool_ops = {
        .set_phys_id = qede_set_phys_id,
        .get_ethtool_stats = qede_get_ethtool_stats,
        .get_priv_flags = qede_get_priv_flags,
+       .set_priv_flags = qede_set_priv_flags,
        .get_sset_count = qede_get_sset_count,
        .get_rxnfc = qede_get_rxnfc,
        .set_rxnfc = qede_set_rxnfc,