ACPI / x86: boot: Swap variables in condition in acpi_register_gsi_ioapic()
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Fri, 15 Dec 2017 21:25:08 +0000 (23:25 +0200)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Thu, 28 Dec 2017 11:36:45 +0000 (12:36 +0100)
For better readability compare input to something considered settled
down. Additionally move it to one line (while it's slightly longer
80 characters it makes readability better).

No functional change intended.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
arch/x86/kernel/acpi/boot.c

index f4c463df8b0886816c5b32a989396fe5e0f714f0..4bad714d622779dba925b7b75497dc86283b284a 100644 (file)
@@ -676,8 +676,7 @@ static int acpi_register_gsi_ioapic(struct device *dev, u32 gsi,
        mutex_lock(&acpi_ioapic_lock);
        irq = mp_map_gsi_to_irq(gsi, IOAPIC_MAP_ALLOC, &info);
        /* Don't set up the ACPI SCI because it's already set up */
-       if (irq >= 0 && enable_update_mptable &&
-           acpi_gbl_FADT.sci_interrupt != gsi)
+       if (irq >= 0 && enable_update_mptable && gsi != acpi_gbl_FADT.sci_interrupt)
                mp_config_acpi_gsi(dev, gsi, trigger, polarity);
        mutex_unlock(&acpi_ioapic_lock);
 #endif