vhost: Fix vhost_copy_to_user()
authorEric Auger <eric.auger@redhat.com>
Wed, 11 Apr 2018 13:30:38 +0000 (15:30 +0200)
committerDavid S. Miller <davem@davemloft.net>
Wed, 11 Apr 2018 14:52:34 +0000 (10:52 -0400)
vhost_copy_to_user is used to copy vring used elements to userspace.
We should use VHOST_ADDR_USED instead of VHOST_ADDR_DESC.

Fixes: f88949138058 ("vhost: introduce O(1) vq metadata cache")
Signed-off-by: Eric Auger <eric.auger@redhat.com>
Acked-by: Jason Wang <jasowang@redhat.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/vhost/vhost.c

index bec722e41f5831be0890a1f4c02f1e486782efef..f44aead98d604335af5b4c20737568bb3e7b665d 100644 (file)
@@ -744,7 +744,7 @@ static int vhost_copy_to_user(struct vhost_virtqueue *vq, void __user *to,
                struct iov_iter t;
                void __user *uaddr = vhost_vq_meta_fetch(vq,
                                     (u64)(uintptr_t)to, size,
-                                    VHOST_ADDR_DESC);
+                                    VHOST_ADDR_USED);
 
                if (uaddr)
                        return __copy_to_user(uaddr, from, size);