Staging: gdm724x: tty: Remove unnecessary macro 'gdm_tty_recv'.
authorQuytelda Kahja <quytelda@tamalin.org>
Sun, 18 Feb 2018 20:26:54 +0000 (12:26 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 19 Feb 2018 17:06:36 +0000 (18:06 +0100)
Remove the macro 'gdm_tty_recv' which adds unnecessary complexity and has
arguments that could mistakenly be evaluated multiple times.

Signed-off-by: Quytelda Kahja <quytelda@tamalin.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/gdm724x/gdm_tty.c

index 1c3853bcfac2e6375b418954633188a8e3d4f587..25357dc3d88cc944b8d5622afee5f71ae713fd84 100644 (file)
@@ -37,8 +37,6 @@
 
 #define MUX_TX_MAX_SIZE 2048
 
-#define gdm_tty_recv(n, c) (\
-       n->tty_dev->recv_func(n->tty_dev->priv_dev, c))
 #define gdm_tty_send_control(n, r, v, d, l) (\
        n->tty_dev->send_control(n->tty_dev->priv_dev, r, v, d, l))
 
@@ -144,7 +142,8 @@ static int gdm_tty_recv_complete(void *data,
 
        if (!GDM_TTY_READY(gdm)) {
                if (complete == RECV_PACKET_PROCESS_COMPLETE)
-                       gdm_tty_recv(gdm, gdm_tty_recv_complete);
+                       gdm->tty_dev->recv_func(gdm->tty_dev->priv_dev,
+                                               gdm_tty_recv_complete);
                return TO_HOST_PORT_CLOSE;
        }
 
@@ -158,7 +157,8 @@ static int gdm_tty_recv_complete(void *data,
        }
 
        if (complete == RECV_PACKET_PROCESS_COMPLETE)
-               gdm_tty_recv(gdm, gdm_tty_recv_complete);
+               gdm->tty_dev->recv_func(gdm->tty_dev->priv_dev,
+                                       gdm_tty_recv_complete);
 
        return 0;
 }
@@ -253,7 +253,8 @@ int register_lte_tty_device(struct tty_dev *tty_dev, struct device *device)
        }
 
        for (i = 0; i < MAX_ISSUE_NUM; i++)
-               gdm_tty_recv(gdm, gdm_tty_recv_complete);
+               gdm->tty_dev->recv_func(gdm->tty_dev->priv_dev,
+                                       gdm_tty_recv_complete);
 
        return 0;
 }