sata_sx4: pdc20621_{ata|host}_sg() do not need 'tf' parameter
authorSergei Shtylyov <sshtylyov@ru.mvista.com>
Thu, 25 Oct 2012 17:19:12 +0000 (21:19 +0400)
committerJeff Garzik <jgarzik@redhat.com>
Wed, 28 Nov 2012 17:39:44 +0000 (12:39 -0500)
... because those functions don't use this parameter.

While at it, correctly align 'total_len' parameter.

Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
drivers/ata/sata_sx4.c

index 122605593166d8cf0f47e67db27fe11efb297513..7b7127a58f51de8b848086425a50ce1b78560474 100644 (file)
@@ -315,9 +315,8 @@ static int pdc_port_start(struct ata_port *ap)
        return 0;
 }
 
-static inline void pdc20621_ata_sg(struct ata_taskfile *tf, u8 *buf,
-                                  unsigned int portno,
-                                          unsigned int total_len)
+static inline void pdc20621_ata_sg(u8 *buf, unsigned int portno,
+                                  unsigned int total_len)
 {
        u32 addr;
        unsigned int dw = PDC_DIMM_APKT_PRD >> 2;
@@ -337,9 +336,8 @@ static inline void pdc20621_ata_sg(struct ata_taskfile *tf, u8 *buf,
                buf32[dw], buf32[dw + 1]);
 }
 
-static inline void pdc20621_host_sg(struct ata_taskfile *tf, u8 *buf,
-                                   unsigned int portno,
-                                           unsigned int total_len)
+static inline void pdc20621_host_sg(u8 *buf, unsigned int portno,
+                                   unsigned int total_len)
 {
        u32 addr;
        unsigned int dw = PDC_DIMM_HPKT_PRD >> 2;
@@ -486,10 +484,10 @@ static void pdc20621_dma_prep(struct ata_queued_cmd *qc)
        /*
         * Build ATA, host DMA packets
         */
-       pdc20621_host_sg(&qc->tf, &pp->dimm_buf[0], portno, total_len);
+       pdc20621_host_sg(&pp->dimm_buf[0], portno, total_len);
        pdc20621_host_pkt(&qc->tf, &pp->dimm_buf[0], portno);
 
-       pdc20621_ata_sg(&qc->tf, &pp->dimm_buf[0], portno, total_len);
+       pdc20621_ata_sg(&pp->dimm_buf[0], portno, total_len);
        i = pdc20621_ata_pkt(&qc->tf, qc->dev->devno, &pp->dimm_buf[0], portno);
 
        if (qc->tf.flags & ATA_TFLAG_LBA48)