msm: dpu1: no need to check return value of debugfs_create functions

When calling debugfs functions, there is no need to ever check the
return value.  The function can work or not, but the code logic should
never do something different based on this.

Cc: Rob Clark <robdclark@gmail.com>
Cc: Sean Paul <sean@poorly.run>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Jeykumar Sankaran <jsanka@codeaurora.org>
Cc: Jordan Crouse <jcrouse@codeaurora.org>
Cc: Abhinav Kumar <abhinavk@codeaurora.org>
Cc: Bruce Wang <bzwang@chromium.org>
Cc: Sravanthi Kollukuduru <skolluku@codeaurora.org>
Cc: Fritz Koenig <frkoenig@google.com>
Cc: Chandan Uddaraju <chandanu@codeaurora.org>
Cc: linux-arm-msm@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org
Cc: freedreno@lists.freedesktop.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Rob Clark <robdclark@chromium.org>

diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c
index 9f20f397f77da858e028577e16c78158ff7afafc..33cd4ee38f672c40e26d176732bd99b8917a42ec 100644 (file)
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c
@@ -506,8 +506,6 @@ int dpu_core_perf_debugfs_init(struct dpu_kms *dpu_kms, struct dentry *parent)
        struct dentry *entry;
 
        entry = debugfs_create_dir("core_perf", parent);
-       if (IS_ERR_OR_NULL(entry))
-               return -EINVAL;
 
        debugfs_create_u64("max_core_clk_rate", 0600, entry,
                        &perf->max_core_clk_rate);

diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c
index dfdfa766da8f154a7093ad332001778dca8e7ca7..e92c2c2bb23f406a319fb5e0044aff850b9e075e 100644 (file)
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c
@@ -1266,10 +1266,7 @@ static int _dpu_crtc_init_debugfs(struct drm_crtc *crtc)
 
        dpu_crtc->debugfs_root = debugfs_create_dir(dpu_crtc->name,
                        crtc->dev->primary->debugfs_root);
-       if (!dpu_crtc->debugfs_root)
-               return -ENOMEM;
 
-       /* don't error check these */
        debugfs_create_file("status", 0400,
                        dpu_crtc->debugfs_root,
                        dpu_crtc, &debugfs_status_fops);

diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
index 82bf16d61a4595047b2bb7d36b4430dc423d1101..ea99643a3d6fb9d2648c1ee341f5a3805863072e 100644 (file)
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
@@ -1985,8 +1985,6 @@ static int _dpu_encoder_init_debugfs(struct drm_encoder *drm_enc)
        /* create overall sub-directory for the encoder */
        dpu_enc->debugfs_root = debugfs_create_dir(name,
                        drm_enc->dev->primary->debugfs_root);
-       if (!dpu_enc->debugfs_root)
-               return -ENOMEM;
 
        /* don't error check these */
        debugfs_create_file("status", 0600,

diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
index 0ddc2e5424532c4c58fa8ea470c6f5b285f916af..fb7c04c06416606bd900b3e2f6047e623e2a69db 100644 (file)
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
@@ -142,8 +142,6 @@ static void dpu_debugfs_danger_init(struct dpu_kms *dpu_kms,
                struct dentry *parent)
 {
        struct dentry *entry = debugfs_create_dir("danger", parent);
-       if (IS_ERR_OR_NULL(entry))
-               return;
 
        debugfs_create_file("danger_status", 0600, entry,
                        dpu_kms, &dpu_debugfs_danger_stats_fops);
@@ -218,17 +216,16 @@ void dpu_debugfs_setup_regset32(struct dpu_debugfs_regset32 *regset,
        }
 }
 
-void *dpu_debugfs_create_regset32(const char *name, umode_t mode,
+void dpu_debugfs_create_regset32(const char *name, umode_t mode,
                void *parent, struct dpu_debugfs_regset32 *regset)
 {
        if (!name || !regset || !regset->dpu_kms || !regset->blk_len)
-               return NULL;
+               return;
 
        /* make sure offset is a multiple of 4 */
        regset->offset = round_down(regset->offset, 4);
 
-       return debugfs_create_file(name, mode, parent,
-                       regset, &dpu_fops_regset32);
+       debugfs_create_file(name, mode, parent, regset, &dpu_fops_regset32);
 }
 
 static int dpu_kms_debugfs_init(struct msm_kms *kms, struct drm_minor *minor)
@@ -241,8 +238,6 @@ static int dpu_kms_debugfs_init(struct msm_kms *kms, struct drm_minor *minor)
                return -EINVAL;
 
        entry = debugfs_create_dir("debug", minor->debugfs_root);
-       if (IS_ERR_OR_NULL(entry))
-               return -ENODEV;
 
        debugfs_create_x32(DPU_DEBUGFS_HWMASKNAME, 0600, entry, p);
 

diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h
index 31e9ef96ca5dc2bf2f174f50f203a385c9200ffd..e9f99834483840343e5c2995ce1d6ecaf5ac66e9 100644 (file)
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h
@@ -197,12 +197,8 @@ void dpu_debugfs_setup_regset32(struct dpu_debugfs_regset32 *regset,
  * @mode:   File mode within debugfs
  * @parent: Parent directory entry within debugfs, can be NULL
  * @regset: Pointer to persistent register block definition
- *
- * Return: dentry pointer for newly created file, use either debugfs_remove()
- *         or debugfs_remove_recursive() (on a parent directory) to remove the
- *         file
  */
-void *dpu_debugfs_create_regset32(const char *name, umode_t mode,
+void dpu_debugfs_create_regset32(const char *name, umode_t mode,
                void *parent, struct dpu_debugfs_regset32 *regset);
 
 /**

diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c
index ce1a555e1f31103cfd08b7a8b4bfa902e1e15f04..36c2b38805c3da4ba7c870cce3eb97e771218db8 100644 (file)
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c
@@ -1329,9 +1329,6 @@ static int _dpu_plane_init_debugfs(struct drm_plane *plane)
                debugfs_create_dir(pdpu->pipe_name,
                                plane->dev->primary->debugfs_root);
 
-       if (!pdpu->debugfs_root)
-               return -ENOMEM;
-
        /* don't error check these */
        debugfs_create_x32("features", 0600,
                        pdpu->debugfs_root, &pdpu->features);

diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_vbif.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_vbif.c
index ef753ea9c4999a0341b35391aeb46a37f4858dff..a0d5ff8624fd65b0b51324b3383167657e04e010 100644 (file)
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_vbif.c
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_vbif.c
@@ -318,8 +318,6 @@ void dpu_debugfs_vbif_init(struct dpu_kms *dpu_kms, struct dentry *debugfs_root)
        int i, j;
 
        entry = debugfs_create_dir("vbif", debugfs_root);
-       if (IS_ERR_OR_NULL(entry))
-               return;
 
        for (i = 0; i < dpu_kms->catalog->vbif_count; i++) {
                struct dpu_vbif_cfg *vbif = &dpu_kms->catalog->vbif[i];
@@ -327,8 +325,6 @@ void dpu_debugfs_vbif_init(struct dpu_kms *dpu_kms, struct dentry *debugfs_root)
                snprintf(vbif_name, sizeof(vbif_name), "%d", vbif->id);
 
                debugfs_vbif = debugfs_create_dir(vbif_name, entry);
-               if (IS_ERR_OR_NULL(debugfs_vbif))
-                       continue;
 
                debugfs_create_u32("features", 0600, debugfs_vbif,
                        (u32 *)&vbif->features);