staging: vt6656: simplify tests of successful urb status
authorAlison Schofield <amsfield22@gmail.com>
Wed, 17 Feb 2016 17:45:28 +0000 (09:45 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 20 Feb 2016 23:22:18 +0000 (15:22 -0800)
Use if (status) in tests for successful urb status.

This replaces (status != 0) and (status == STATUS_SUCCESS).
(STATUS_SUCCESS is defined for NDIS status in this driver, but
was being misused)

Signed-off-by: Alison Schofield <amsfield22@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/vt6656/usbpipe.c

index f27eb9a8d249a518007c08a348cc5ed8c597152c..f546553de66fb7cc649ef2c67fabdb90119d74fb 100644 (file)
@@ -116,7 +116,7 @@ static void vnt_start_interrupt_urb_complete(struct urb *urb)
                break;
        }
 
-       if (status != STATUS_SUCCESS) {
+       if (status) {
                priv->int_buf.in_use = false;
 
                dev_dbg(&priv->usb->dev, "%s status = %d\n", __func__, status);
@@ -221,7 +221,7 @@ int vnt_submit_rx_urb(struct vnt_private *priv, struct vnt_rcb *rcb)
                          rcb);
 
        status = usb_submit_urb(urb, GFP_ATOMIC);
-       if (status != 0) {
+       if (status) {
                dev_dbg(&priv->usb->dev, "Submit Rx URB failed %d\n", status);
                return STATUS_FAILURE;
        }
@@ -282,7 +282,7 @@ int vnt_tx_context(struct vnt_private *priv,
                          context);
 
        status = usb_submit_urb(urb, GFP_ATOMIC);
-       if (status != 0) {
+       if (status) {
                dev_dbg(&priv->usb->dev, "Submit Tx URB failed %d\n", status);
 
                context->in_use = false;