regulator: tps6524x: Remove *rdev[N_REGULATORS] from struct tps6524x
authorAxel Lin <axel.lin@ingics.com>
Sat, 13 Apr 2019 07:30:02 +0000 (15:30 +0800)
committerMark Brown <broonie@kernel.org>
Mon, 15 Apr 2019 08:44:41 +0000 (09:44 +0100)
Current code is using devm_regulator_register() so we don't need to store
*rdev for clean up, use a local variable instead.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/regulator/tps6524x-regulator.c

index c09223c34dbfb02fb9dfc81de3ed9e36939e024b..740aeccdfb1ff53d0c0a77e685f9031b451eac0d 100644 (file)
@@ -137,7 +137,6 @@ struct tps6524x {
        struct spi_device       *spi;
        struct mutex            lock;
        struct regulator_desc   desc[N_REGULATORS];
-       struct regulator_dev    *rdev[N_REGULATORS];
 };
 
 static int __read_reg(struct tps6524x *hw, int reg)
@@ -584,6 +583,7 @@ static int pmic_probe(struct spi_device *spi)
        const struct supply_info *info = supply_info;
        struct regulator_init_data *init_data;
        struct regulator_config config = { };
+       struct regulator_dev *rdev;
        int i;
 
        init_data = dev_get_platdata(dev);
@@ -616,10 +616,9 @@ static int pmic_probe(struct spi_device *spi)
                config.init_data = init_data;
                config.driver_data = hw;
 
-               hw->rdev[i] = devm_regulator_register(dev, &hw->desc[i],
-                                                     &config);
-               if (IS_ERR(hw->rdev[i]))
-                       return PTR_ERR(hw->rdev[i]);
+               rdev = devm_regulator_register(dev, &hw->desc[i], &config);
+               if (IS_ERR(rdev))
+                       return PTR_ERR(rdev);
        }
 
        return 0;