udmabuf: use EBADFD in case we didn't got a memfd

Reported-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: http://patchwork.freedesktop.org/patch/msgid/20180911134216.9760-10-kraxel@redhat.com

diff --git a/drivers/dma-buf/udmabuf.c b/drivers/dma-buf/udmabuf.c
index a3d225fd4d908ba9bbbe339e539e5882030d3fcf..e0465a9bf3f93949a33c646bb51b8b8c388ca512 100644 (file)
--- a/drivers/dma-buf/udmabuf.c
+++ b/drivers/dma-buf/udmabuf.c
@@ -154,14 +154,17 @@ static long udmabuf_create(const struct udmabuf_create_list *head,
 
        pgbuf = 0;
        for (i = 0; i < head->count; i++) {
+               ret = -EBADFD;
                memfd = fget(list[i].memfd);
                if (!memfd)
                        goto err;
                if (!shmem_mapping(file_inode(memfd)->i_mapping))
                        goto err;
                seals = memfd_fcntl(memfd, F_GET_SEALS, 0);
-               if (seals == -EINVAL ||
-                   (seals & SEALS_WANTED) != SEALS_WANTED ||
+               if (seals == -EINVAL)
+                       goto err;
+               ret = -EINVAL;
+               if ((seals & SEALS_WANTED) != SEALS_WANTED ||
                    (seals & SEALS_DENIED) != 0)
                        goto err;
                pgoff = list[i].offset >> PAGE_SHIFT;