V4L/DVB: drivers/media/video/zoran: Use kmemdup

Use kmemdup when some other buffer is immediately copied into the
allocated region.

A simplified version of the semantic patch that makes this change is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@@
expression from,to,size,flag;
statement S;
@@

-  to = \(kmalloc\|kzalloc\)(size,flag);
+  to = kmemdup(from,size,flag);
   if (to==NULL || ...) S
-  memcpy(to, from, size);
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Douglas Schilling Landgraf <dougsland@redhat.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

diff --git a/drivers/media/video/zoran/videocodec.c b/drivers/media/video/zoran/videocodec.c
index cf24956f3204272cd6b9eeebb5ecf7b8c20ffeaa..c010716352903e3000ea56278df4edc290a7b320 100644 (file)
--- a/drivers/media/video/zoran/videocodec.c
+++ b/drivers/media/video/zoran/videocodec.c
@@ -107,15 +107,14 @@ videocodec_attach (struct videocodec_master *master)
                        if (!try_module_get(h->codec->owner))
                                return NULL;
 
-                       codec =
-                           kmalloc(sizeof(struct videocodec), GFP_KERNEL);
+                       codec = kmemdup(h->codec, sizeof(struct videocodec),
+                                       GFP_KERNEL);
                        if (!codec) {
                                dprintk(1,
                                        KERN_ERR
                                        "videocodec_attach: no mem\n");
                                goto out_module_put;
                        }
-                       memcpy(codec, h->codec, sizeof(struct videocodec));
 
                        snprintf(codec->name, sizeof(codec->name),
                                 "%s[%d]", codec->name, h->attached);