dmxdev: get rid of pointless clearing ->f_op
authorAl Viro <viro@zeniv.linux.org.uk>
Sun, 22 Sep 2013 18:33:32 +0000 (14:33 -0400)
committerAl Viro <viro@zeniv.linux.org.uk>
Fri, 25 Oct 2013 03:34:53 +0000 (23:34 -0400)
nobody else will see that struct file after return from ->release()
anyway; just leave ->f_op as is and let __fput() do that fops_put().

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
drivers/media/dvb-core/dmxdev.c

index 0b4616b8719594560a70a1dfb977a206de5eba4b..c0363f1b6c90e06c34409766e4a69c56fb98164f 100644 (file)
@@ -206,8 +206,6 @@ static int dvb_dvr_release(struct inode *inode, struct file *file)
        /* TODO */
        dvbdev->users--;
        if (dvbdev->users == 1 && dmxdev->exit == 1) {
-               fops_put(file->f_op);
-               file->f_op = NULL;
                mutex_unlock(&dmxdev->mutex);
                wake_up(&dvbdev->wait_queue);
        } else
@@ -1120,8 +1118,6 @@ static int dvb_demux_release(struct inode *inode, struct file *file)
        mutex_lock(&dmxdev->mutex);
        dmxdev->dvbdev->users--;
        if(dmxdev->dvbdev->users==1 && dmxdev->exit==1) {
-               fops_put(file->f_op);
-               file->f_op = NULL;
                mutex_unlock(&dmxdev->mutex);
                wake_up(&dmxdev->dvbdev->wait_queue);
        } else