[media] omap3isp: Fix buffer flags handling when querying buffer
authorLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Tue, 10 Dec 2013 01:46:17 +0000 (22:46 -0300)
committerMauro Carvalho Chehab <m.chehab@samsung.com>
Wed, 18 Dec 2013 08:25:04 +0000 (06:25 -0200)
A missing break resulted in all done buffers being flagged with
V4L2_BUF_FLAG_QUEUED. Fix it.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Acked-by: Sakari Ailus <sakari.ailus@iki.fi>
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
drivers/media/platform/omap3isp/ispqueue.c

index e15f01342058579413c5742b366b0a8c5f39ac56..5f0f8fab1d1736440b66c0a3cef3755ce70dfb22 100644 (file)
@@ -553,8 +553,10 @@ static void isp_video_buffer_query(struct isp_video_buffer *buf,
        switch (buf->state) {
        case ISP_BUF_STATE_ERROR:
                vbuf->flags |= V4L2_BUF_FLAG_ERROR;
+               /* Fallthrough */
        case ISP_BUF_STATE_DONE:
                vbuf->flags |= V4L2_BUF_FLAG_DONE;
+               break;
        case ISP_BUF_STATE_QUEUED:
        case ISP_BUF_STATE_ACTIVE:
                vbuf->flags |= V4L2_BUF_FLAG_QUEUED;