omapfb: add missing of_node_put after of_device_is_available
authorJulia Lawall <Julia.Lawall@lip6.fr>
Mon, 1 Apr 2019 15:46:56 +0000 (17:46 +0200)
committerBartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Mon, 1 Apr 2019 15:46:56 +0000 (17:46 +0200)
Add an of_node_put when a tested device node is not available.

The semantic patch that fixes this problem is as follows
(http://coccinelle.lip6.fr):

// <smpl>
@@
identifier f;
local idexpression e;
expression x;
@@

e = f(...);
... when != of_node_put(e)
    when != x = e
    when != e = x
    when any
if (<+...of_device_is_available(e)...+>) {
  ... when != of_node_put(e)
(
  return e;
|
+ of_node_put(e);
  return ...;
)
}
// </smpl>

Fixes: f76ee892a99e6 ("omapfb: copy omapdss & displays for omapfb")
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
drivers/video/fbdev/omap2/omapfb/dss/omapdss-boot-init.c

index 136d30484d02345430a1875d49acffa836c8a059..cb6acbac9c47bfb4e768c15678570b656ec246ba 100644 (file)
@@ -193,8 +193,10 @@ static int __init omapdss_boot_init(void)
 
        dss = of_find_matching_node(NULL, omapdss_of_match);
 
-       if (dss == NULL || !of_device_is_available(dss))
+       if (dss == NULL || !of_device_is_available(dss)) {
+               of_node_put(dss);
                return 0;
+       }
 
        omapdss_walk_device(dss, true);