staging: comedi: amplc_pci230: no need to comedi_set_hw_dev() here
authorIan Abbott <abbotti@mev.co.uk>
Mon, 1 Sep 2014 11:03:41 +0000 (12:03 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 2 Sep 2014 18:21:31 +0000 (11:21 -0700)
The comedi core module calls `comedi_set_hw_dev()` to associate the
hardware `struct device` with the `struct comedi_device` before it calls
the comedi driver's "auto_attach" hook `pci230_auto_attach()`.  There is
no need for `pci230_auto_attach()` to call `comedi_set_hw_dev()` itself,
so remove the call.

Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Reviewed-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/comedi/drivers/amplc_pci230.c

index 46977e53a16d37cebd8c85a4886c8384a30e2988..bd2e6483ac55a4c9298765c5f0b8e5113e0c66e4 100644 (file)
@@ -2582,8 +2582,6 @@ static int pci230_auto_attach(struct comedi_device *dev,
        thisboard = comedi_board(dev);
        devpriv = dev->private;
 
-       comedi_set_hw_dev(dev, &pci_dev->dev);
-
        dev->board_name = thisboard->name;
 
        rc = comedi_pci_enable(dev);