libata: hardreset on SERR_INTERNAL
authorTejun Heo <htejun@gmail.com>
Tue, 13 Mar 2007 16:20:51 +0000 (01:20 +0900)
committerJeff Garzik <jeff@garzik.org>
Sat, 28 Apr 2007 18:15:59 +0000 (14:15 -0400)
There was a rare report where SB600 reported SERR_INTERNAL and SRST
couldn't get it out of the failure mode.  Hardreset on SERR_INTERNAL.
As the problem is intermittent, whether this fixes the problem or not
hasn't been verified yet, but hardresetting the channel on internal
error is a good idea anyway.

Signed-off-by: Tejun Heo <htejun@gmail.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
drivers/ata/libata-eh.c

index 39f556c0299265ffb99a4430588f7aa9cac194ff..185876aba64742acadef65193c26c286c5e14acf 100644 (file)
@@ -1056,7 +1056,7 @@ static void ata_eh_analyze_serror(struct ata_port *ap)
        }
        if (serror & SERR_INTERNAL) {
                err_mask |= AC_ERR_SYSTEM;
-               action |= ATA_EH_SOFTRESET;
+               action |= ATA_EH_HARDRESET;
        }
        if (serror & (SERR_PHYRDY_CHG | SERR_DEV_XCHG))
                ata_ehi_hotplugged(&ehc->i);