net: aquantia: fix error handling in aq_ptp_poll
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Mon, 28 Oct 2019 07:04:47 +0000 (02:04 -0500)
committerDavid S. Miller <davem@davemloft.net>
Tue, 29 Oct 2019 23:42:17 +0000 (16:42 -0700)
Fix currenty ignored returned error by properly checking *err* after
calling aq_nic->aq_hw_ops->hw_ring_hwts_rx_fill().

Addresses-Coverity-ID: 1487357 ("Unused value")
Fixes: 04a1839950d9 ("net: aquantia: implement data PTP datapath")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Reviewed-by: Igor Russkikh <irusskikh@marvell.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/aquantia/atlantic/aq_ptp.c

index 4ca36003c6ca8bf73ba18d24874f321026f63a15..8175513e48c9c342f00960603462cf7bd4b86704 100644 (file)
@@ -678,6 +678,8 @@ static int aq_ptp_poll(struct napi_struct *napi, int budget)
 
                err = aq_nic->aq_hw_ops->hw_ring_hwts_rx_fill(aq_nic->aq_hw,
                                                              &aq_ptp->hwts_rx);
+               if (err < 0)
+                       goto err_exit;
 
                was_cleaned = true;
        }