staging: lustre: ptlrpc: sec_plain: remove unneeded null test before free
authorJulia Lawall <Julia.Lawall@lip6.fr>
Fri, 1 May 2015 19:37:48 +0000 (21:37 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 8 May 2015 07:23:56 +0000 (09:23 +0200)
Kfree can cope with a null argument, so drop null tests.

The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@ expression ptr; @@

- if (ptr != NULL)
  kfree(ptr);
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/lustre/lustre/ptlrpc/sec_plain.c

index 604e51177bd3c35f2dd0a238410c4362fb332484..989cdcda27b56578567c12a8fa2de35d55638aa4 100644 (file)
@@ -384,8 +384,7 @@ struct ptlrpc_cli_ctx *plain_sec_install_ctx(struct plain_sec *plsec)
        if (ctx) {
                atomic_inc(&ctx->cc_refcount);
 
-               if (ctx_new)
-                       kfree(ctx_new);
+               kfree(ctx_new);
        } else if (ctx_new) {
                ctx = ctx_new;