drm/i915: Always mark the PDP as dirty when altered
authorChris Wilson <chris@chris-wilson.co.uk>
Wed, 15 Feb 2017 08:43:51 +0000 (08:43 +0000)
committerChris Wilson <chris@chris-wilson.co.uk>
Wed, 15 Feb 2017 10:07:29 +0000 (10:07 +0000)
We want to reload the PDP (and flush the TLB) when the addresses are
changed.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Matthew Auld <matthew.auld@intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/20170215084357.19977-17-chris@chris-wilson.co.uk
drivers/gpu/drm/i915/i915_gem_gtt.c

index 234a65e8f7b11af8a938f7d15bdea934498280e4..9db033c8e7c53e85c112616b2bd40e7cde207115 100644 (file)
@@ -1085,7 +1085,6 @@ static int gen8_ppgtt_alloc_pdp(struct i915_address_space *vm,
                                struct i915_page_directory_pointer *pdp,
                                u64 start, u64 length)
 {
-       struct i915_hw_ppgtt *ppgtt = i915_vm_to_ppgtt(vm);
        struct i915_page_directory *pd;
        u64 from = start;
        unsigned int pdpe;
@@ -1100,6 +1099,8 @@ static int gen8_ppgtt_alloc_pdp(struct i915_address_space *vm,
                        gen8_initialize_pd(vm, pd);
                        gen8_ppgtt_set_pdpe(vm, pdp, pd, pdpe);
                        pdp->used_pdpes++;
+
+                       mark_tlbs_dirty(i915_vm_to_ppgtt(vm));
                }
 
                ret = gen8_ppgtt_alloc_pd(vm, pd, start, length);
@@ -1111,7 +1112,6 @@ static int gen8_ppgtt_alloc_pdp(struct i915_address_space *vm,
                }
        }
 
-       mark_tlbs_dirty(ppgtt);
        return 0;
 
 unwind: