posix-timers: Use spin_lock_irq() in itimer_delete()

itimer_delete() uses spin_lock_irqsave() to obtain a `flags' variable
which can then be passed to unlock_timer(). It uses already spin_lock
locking for the structure instead of lock_timer() because it has a timer
which can not be removed by others at this point. The cleanup is always
performed with enabled interrupts.

Use spin_lock_irq() / spin_unlock_irq() so the `flags' variable can be
removed.

Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Link: https://lkml.kernel.org/r/20190621143643.25649-3-bigeasy@linutronix.de

diff --git a/kernel/time/posix-timers.c b/kernel/time/posix-timers.c
index caa63e58e3d885f98739f24383e95bb74b5ef381..d7f2d91acdac1feda92cbec236afada11ff74cbe 100644 (file)
--- a/kernel/time/posix-timers.c
+++ b/kernel/time/posix-timers.c
@@ -980,18 +980,16 @@ retry_delete:
  */
 static void itimer_delete(struct k_itimer *timer)
 {
-       unsigned long flags;
-
 retry_delete:
-       spin_lock_irqsave(&timer->it_lock, flags);
+       spin_lock_irq(&timer->it_lock);
 
        if (timer_delete_hook(timer) == TIMER_RETRY) {
-               unlock_timer(timer, flags);
+               spin_unlock_irq(&timer->it_lock);
                goto retry_delete;
        }
        list_del(&timer->list);
 
-       unlock_timer(timer, flags);
+       spin_unlock_irq(&timer->it_lock);
        release_posix_timer(timer, IT_ID_SET);
 }