staging: rtl8188eu: Remove _ReadLEDSetting() function.
authornavin patidar <navin.patidar@gmail.com>
Sun, 20 Apr 2014 08:47:11 +0000 (14:17 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 25 Apr 2014 22:59:50 +0000 (15:59 -0700)
_ReadLEDSetting() doesn't read led settings this function actually
initialize  member variables of struct led_priv, we should do that
inside rtl8188eu_InitSwLeds().

Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8188eu/hal/rtl8188eu_led.c
drivers/staging/rtl8188eu/hal/usb_halinit.c

index 08dfd94163e6b078e5c9643e8b7921d621e0ee72..01eeb7080717f2c1f266948d5490bc35412609e8 100644 (file)
@@ -92,8 +92,12 @@ exit:
 void rtl8188eu_InitSwLeds(struct adapter *padapter)
 {
        struct led_priv *pledpriv = &(padapter->ledpriv);
+       struct hal_data_8188e   *haldata = GET_HAL_DATA(padapter);
 
+       pledpriv->bRegUseLed = true;
+       pledpriv->LedStrategy = SW_LED_MODE1;
        pledpriv->LedControlHandler = LedControl8188eu;
+       haldata->bLedOpenDrain = true;
 
        InitLed871x(padapter, &(pledpriv->SwLed0), LED_PIN_LED0);
 
index c92067f0ef1551dd66496fc58ebd9e4a81a76373..0dfd62b6378a37bf3a97ed099ac329d132d210b5 100644 (file)
@@ -1129,16 +1129,6 @@ static unsigned int rtl8188eu_inirp_deinit(struct adapter *Adapter)
 /*     EEPROM/EFUSE Content Parsing */
 /*  */
 /*  */
-static void _ReadLEDSetting(struct adapter *Adapter, u8 *PROMContent, bool AutoloadFail)
-{
-       struct led_priv *pledpriv = &(Adapter->ledpriv);
-       struct hal_data_8188e   *haldata = GET_HAL_DATA(Adapter);
-
-       pledpriv->bRegUseLed = true;
-       pledpriv->LedStrategy = SW_LED_MODE1;
-       haldata->bLedOpenDrain = true;/*  Support Open-drain arrangement for controlling the LED. */
-}
-
 static void Hal_EfuseParsePIDVID_8188EU(struct adapter *adapt, u8 *hwinfo, bool AutoLoadFail)
 {
        struct hal_data_8188e   *haldata = GET_HAL_DATA(adapt);
@@ -1215,8 +1205,6 @@ readAdapterInfo_8188EU(
        /*  */
        Hal_InitChannelPlan(adapt);
        Hal_CustomizeByCustomerID_8188EU(adapt);
-
-       _ReadLEDSetting(adapt, eeprom->efuse_eeprom_data, eeprom->bautoload_fail_flag);
 }
 
 static void _ReadPROMContent(