ice: update driver unloading field for Queue Shutdown AQ command
authorBruce Allan <bruce.w.allan@intel.com>
Fri, 2 Aug 2019 08:25:30 +0000 (01:25 -0700)
committerJeff Kirsher <jeffrey.t.kirsher@intel.com>
Tue, 3 Sep 2019 23:23:35 +0000 (16:23 -0700)
According to recent specification versions, the field in the Queue Shutdown
AdminQ command consisting of the "driver unloading" indication is not a 4
byte field (it is byte.bit 16.0).  Change it to a byte and remove the
unnecessary endian conversion.

Signed-off-by: Bruce Allan <bruce.w.allan@intel.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
drivers/net/ethernet/intel/ice/ice_adminq_cmd.h
drivers/net/ethernet/intel/ice/ice_common.c

index bf9aa533a7c65d5f00383dbe44f750d657faf816..8ebc695171b67fe0731455b4f11962f468d58b59 100644 (file)
@@ -35,9 +35,9 @@ struct ice_aqc_get_ver {
 
 /* Queue Shutdown (direct 0x0003) */
 struct ice_aqc_q_shutdown {
-       __le32 driver_unloading;
+       u8 driver_unloading;
 #define ICE_AQC_DRIVER_UNLOADING       BIT(0)
-       u8 reserved[12];
+       u8 reserved[15];
 };
 
 /* Request resource ownership (direct 0x0008)
index 302ad981129cbfa81f1640729ff31ae5b7e372c5..6c0abb284c103d9c95ccd80d20fd0ba912f0f8ef 100644 (file)
@@ -1275,7 +1275,7 @@ enum ice_status ice_aq_q_shutdown(struct ice_hw *hw, bool unloading)
        ice_fill_dflt_direct_cmd_desc(&desc, ice_aqc_opc_q_shutdown);
 
        if (unloading)
-               cmd->driver_unloading = cpu_to_le32(ICE_AQC_DRIVER_UNLOADING);
+               cmd->driver_unloading = ICE_AQC_DRIVER_UNLOADING;
 
        return ice_aq_send_cmd(hw, &desc, NULL, 0, NULL);
 }