drm/bridge: ti-sn65dsi86: Move panel_prepare() to pre_enable()
authorSean Paul <seanpaul@chromium.org>
Mon, 13 Aug 2018 21:30:43 +0000 (17:30 -0400)
committerSean Paul <seanpaul@chromium.org>
Tue, 14 Aug 2018 18:05:47 +0000 (14:05 -0400)
prepare() is the old-timey way to say pre_enable(). It should be called
before modeset. This fixes an issue where the panel on cheza must have
the regulator always-on/boot-on for it to work.

Changes in v3:
- Added to the set

Cc: Sandeep Panda <spanda@codeaurora.org>
Reviewed-by: Sandeep Panda <spanda@codeaurora.org>
Signed-off-by: Sean Paul <seanpaul@chromium.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20180813213058.184821-5-sean@poorly.run
drivers/gpu/drm/bridge/ti-sn65dsi86.c

index 501f4a81ea5ab3e1845dd64742af2b2aaa9425ca..d2119ab546147df0471b4b3901eecc5b4e76703f 100644 (file)
@@ -457,8 +457,6 @@ static void ti_sn_bridge_enable(struct drm_bridge *bridge)
        struct ti_sn_bridge *pdata = bridge_to_ti_sn_bridge(bridge);
        unsigned int val;
 
-       drm_panel_prepare(pdata->panel);
-
        /* DSI_A lane config */
        val = CHA_DSI_LANES(4 - pdata->dsi->lanes);
        regmap_update_bits(pdata->regmap, SN_DSI_LANES_REG,
@@ -511,6 +509,8 @@ static void ti_sn_bridge_pre_enable(struct drm_bridge *bridge)
        /* in case drm_panel is connected then HPD is not supported */
        regmap_update_bits(pdata->regmap, SN_HPD_DISABLE_REG, HPD_DISABLE,
                           HPD_DISABLE);
+
+       drm_panel_prepare(pdata->panel);
 }
 
 static void ti_sn_bridge_post_disable(struct drm_bridge *bridge)