iwl-4965: test below 0 on unsigned num_tbs
authorroel kluin <roel.kluin@gmail.com>
Tue, 22 Jul 2008 00:29:52 +0000 (20:29 -0400)
committerJohn W. Linville <linville@tuxdriver.com>
Fri, 22 Aug 2008 20:29:51 +0000 (16:29 -0400)
num_tbs is unsigned so the test doesn't work.

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
drivers/net/wireless/iwlwifi/iwl-tx.c

index d82823b5c8abce08948fad392cd9e8c3368aabf5..dac34aa8358e1dce8c6453a0644506b975681518 100644 (file)
@@ -126,7 +126,7 @@ int iwl_hw_txq_attach_buf_to_tfd(struct iwl_priv *priv, void *ptr,
        u32 num_tbs = IWL_GET_BITS(*tfd, num_tbs);
 
        /* Each TFD can point to a maximum 20 Tx buffers */
-       if ((num_tbs >= MAX_NUM_OF_TBS) || (num_tbs < 0)) {
+       if (num_tbs >= MAX_NUM_OF_TBS) {
                IWL_ERROR("Error can not send more than %d chunks\n",
                          MAX_NUM_OF_TBS);
                return -EINVAL;