drm/i915/execlists: Detect cross-contamination with GuC
authorChris Wilson <chris@chris-wilson.co.uk>
Tue, 18 Jun 2019 11:07:36 +0000 (12:07 +0100)
committerChris Wilson <chris@chris-wilson.co.uk>
Wed, 19 Jun 2019 11:18:14 +0000 (12:18 +0100)
The process_csb routine from execlists_submission is incompatible with
the GuC backend. Add a warning to detect if we accidentally end up in
the wrong spot.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
Cc: MichaƂ Winiarski <michal.winiarski@intel.com>
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190618110736.31155-1-chris@chris-wilson.co.uk
drivers/gpu/drm/i915/gt/intel_lrc.c

index df58d1d838f7445fdf77146c02e24f875913fe3f..b42b5f158295953b7b6da42f4846e96b9d4b4afb 100644 (file)
@@ -1169,6 +1169,7 @@ static void process_csb(struct intel_engine_cs *engine)
        u8 head, tail;
 
        lockdep_assert_held(&engine->active.lock);
+       GEM_BUG_ON(USES_GUC_SUBMISSION(engine->i915));
 
        /*
         * Note that csb_write, csb_status may be either in HWSP or mmio.