video: fbdev: imxfb: fix a typo in imxfb_probe()
authorWei Yongjun <weiyongjun1@huawei.com>
Fri, 5 Jul 2019 15:42:13 +0000 (17:42 +0200)
committerBartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Fri, 5 Jul 2019 15:42:13 +0000 (17:42 +0200)
Fix the return value check which testing the wrong variable
in imxfb_probe().

b.zolnierkie: please note that ->screen_base and ->screen_buffer
are equivalent (they are part of unnamed union in struct fb_info)

Fixes: 739a6439c2bf ("video: fbdev: imxfb: fix sparse warnings about using incorrect types")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Cc: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: Fabio Estevam <festevam@gmail.com>
Cc: NXP Linux Team <linux-imx@nxp.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
drivers/video/fbdev/imxfb.c

index 8d1053e9ef9f7c708e08e855bd22e6d76be93835..b3286d1fa5439a3ac4f0675a8c40fd5368dda842 100644 (file)
@@ -976,7 +976,7 @@ static int imxfb_probe(struct platform_device *pdev)
        fbi->map_size = PAGE_ALIGN(info->fix.smem_len);
        info->screen_buffer = dma_alloc_wc(&pdev->dev, fbi->map_size,
                                           &fbi->map_dma, GFP_KERNEL);
-       if (!info->screen_base) {
+       if (!info->screen_buffer) {
                dev_err(&pdev->dev, "Failed to allocate video RAM: %d\n", ret);
                ret = -ENOMEM;
                goto failed_map;